New issue
Advanced search Search tips

Issue 892633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 5
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 729596



Sign in to add a comment

Fix browsertests failures in TaskTracker when starting TaskScheduler early

Project Member Reported by hanxi@chromium.org, Oct 5

Issue description

The print stack is:
  [ RUN      ] NativeBindings/MessagingApiTest.MessagingUserGesture/0
  Xlib:  extension "RANDR" missing on display ":99".
  [24857:24884:0926/140552.212012:FATAL:task_tracker.cc(741)] Check failed: preemption_state_[priority_index].current_scheduled_sequences <= preemption_state_[priority_index].max_scheduled_sequences (1 vs. 0)
  #0 0x00000684b64c base::debug::StackTrace::StackTrace()
  #1 0x00000679547b logging::LogMessage::~LogMessage()
  #2 0x00000680ece4 base::internal::TaskTracker::GetPreemptedSequenceToScheduleLockRequired()
  #3 0x00000680e1f8 base::internal::TaskTracker::ManageSequencesAfterRunningTask()
  #4 0x00000680dba9 base::internal::TaskTracker::RunAndPopNextTask()
  #5 0x00000680955d base::internal::SchedulerWorker::RunWorker()
  #6 0x0000068092e4 base::internal::SchedulerWorker::RunPooledWorker()
  #7 0x00000685fb3f base::(anonymous namespace)::ThreadFunc()
  #8 0x7f4116066184 start_thread
  #9 0x7f411029303d clone

The browsertests failsures are seen in CL (https://chromium-review.googlesource.com/c/chromium/src/+/1174955).
 
Blocking: 729596
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc43e59838736c799542d7713b6a9f54c25131e6

commit cc43e59838736c799542d7713b6a9f54c25131e6
Author: Xi Han <hanxi@google.com>
Date: Fri Oct 05 18:54:47 2018

Fix browsertests failures in TaskTracker when starting TaskScheduler early

Add an additional check before calling
GetPreemptedSequenceToScheduleLockRequired().

Bug:  892633 
Change-Id: I7ee9bcf1e05a96dbabb9378fc6ea99118e0810fe
Reviewed-on: https://chromium-review.googlesource.com/c/1263894
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597220}
[modify] https://crrev.com/cc43e59838736c799542d7713b6a9f54c25131e6/base/task/task_scheduler/task_tracker.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment