A tracking bug for another manual sync of LayoutTests/resources/ and LayoutTests/external/wpt/resources/, as it requires more changes than usual. This is because of these upstream changes: https://github.com/web-platform-tests/wpt/pull/12898 https://github.com/web-platform-tests/wpt/pull/12958 https://github.com/web-platform-tests/wpt/pull/12976
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de4bbddf1ce967f3903b04d91897e7a602a88bb1 commit de4bbddf1ce967f3903b04d91897e7a602a88bb1 Author: Philip Jägenstedt <foolip@chromium.org> Date: Fri Oct 05 21:33:56 2018 Stop using `assert_exists` and `assert_not_exists` These have been removed in wpt's testharness.js: https://github.com/web-platform-tests/wpt/pull/12976 This is blocking updating LayoutTests/resources/testharness.js. `assert_exists` was blindly replaced with `assert_own_property` in all files (s/assert_own_property/assert_exists/g) and `assert_not_exists` was changed on a case-by-case basis. Bug: 892613 Change-Id: Ied0d7952c5737b5afe50088cdd8be2c9629d40b7 Reviewed-on: https://chromium-review.googlesource.com/c/1264641 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#597310} [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/animations/animation-finish-promise-gc.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/css3/masking/clip-path-selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/assert_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/deleting/delete_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/deleting/smart_editing_disabled.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/execCommand/clipboard-access-with-userGesture.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/execCommand/remove_format_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/execCommand/transpose_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/execCommand/unlink_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/inserting/insert-composition-whitespace.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/inserting/insert-on-unfocused-element.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/inserting/insert-text-nodes-disconnect-on-textinput-event.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/inserting/insert-text-remove-iframe-on-textInput-event.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/pasteboard/pasteboard_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/arrow_key_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_before_select.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_document_in_design_mode.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_html_to_editable_body.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-3.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/double_click_and_modify.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/mark_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/modify_move/resources/move-by-word-visually.js [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/mouse/extend_by_word_with_base_is_end.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/select-bidi-run.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/select-out-of-floated-non-editable.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/shift-click.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/unrendered-001.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/user-select-all-with-shift.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/selection/user-select/user-select-all.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/editing/style/apply_style_with_unfocused_selection.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/dom/htmlformcontrolscollection-no-img.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/dom/shadow/content-selector-query.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/events/click-with-large-negative-text-indent.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/events/content-changed-during-drop.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/events/contextmenu-follows-focus.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/events/dispatch-mouse-events-to-window-always.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/label/label-selection-by-textSelection-and-click.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/radio/radio-input-keyboard-navigation.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/text-control-selection-after-blur.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-clear-in-submit.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-resize-above-min-size-and-below-initial-size.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-resize-below-min-intrinsic-size.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-resize-below-min-size-zoomed.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-resize-below-min-size.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-resize-orthogonal-containing-block.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/forms/validation-bubble-update.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/peerconnection/RTCRtpSender-getParameters.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/fast/text/hyphens/can-hyphenate-locale.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/test-inputs.js [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials-worker.js [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/svg/dom/svgangle-units.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/svg/dom/svglength-units.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/svg/dom/tooltip-title-external-svg.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/svg/dom/tooltip-title-inline-svg.html [modify] https://crrev.com/de4bbddf1ce967f3903b04d91897e7a602a88bb1/third_party/WebKit/LayoutTests/svg/text/select-text-vertical.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a92a752c233e4eeb44370d73bbaea1823905ce7 commit 1a92a752c233e4eeb44370d73bbaea1823905ce7 Author: Philip Jägenstedt <foolip@chromium.org> Date: Mon Oct 08 10:32:35 2018 Switch a `promise_test` to a plain synchronous `test` This adapts to "Reject non-thenable values" upstream: https://github.com/web-platform-tests/wpt/pull/12898 This is blocking updating LayoutTests/resources/testharness.js. Bug: 892613 Change-Id: Ifbc91824c0a5687a74cc6f16e02457da60dc4e85 Reviewed-on: https://chromium-review.googlesource.com/c/1264585 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#597521} [modify] https://crrev.com/1a92a752c233e4eeb44370d73bbaea1823905ce7/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-Id.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2da5ac7f55e19bbab0497e9afa00fdddc5d16496 commit 2da5ac7f55e19bbab0497e9afa00fdddc5d16496 Author: Philip Jägenstedt <foolip@chromium.org> Date: Tue Oct 09 08:01:34 2018 Adapt to "Disallow `test` return value" change in wpt The change in question: https://github.com/web-platform-tests/wpt/pull/12958 This change was done to flag possible test authoring mistakes. While most of the updates in this CL are just adding braces arrow functions, in set-root-scroller.html there was a genuine problem with the test. In assert_selection.js, to avoid updating many many test using `test(() => assert_selection(...), desc)`, change `assert_selection` to not have a return value and add `assert_selection_and_return_sample`. Bug: 892613 Change-Id: Idaee49e40a9d85f5dfb7124c35a0d864bdbf016f Reviewed-on: https://chromium-review.googlesource.com/c/1268341 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#597834} [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/editing/assert_selection.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/editing/assert_selection.js [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/editing/selection/selectstart_detaches_frame.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/editing/text-iterator/first_letter_find_string_crash.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/fast/forms/image/fallback-reattach-crash.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/idle-callback/untriggered-do-not-leak.html [modify] https://crrev.com/2da5ac7f55e19bbab0497e9afa00fdddc5d16496/third_party/WebKit/LayoutTests/rootscroller/set-root-scroller.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/703588673ea6e817e7017fcdee4a70a18342c0dd commit 703588673ea6e817e7017fcdee4a70a18342c0dd Author: Philip Jägenstedt <foolip@chromium.org> Date: Tue Oct 09 10:03:46 2018 Sync LayoutTests/resources/ with LayoutTests/external/wpt/resources/ Roll in the most recent version of: testharness.js, testdriver.js, idlharness.js. (webidl2.js has not changed in wpt) Bug: 892613 Change-Id: I38208e6f796ebd2428716ed53219d5c21a188a90 Reviewed-on: https://chromium-review.googlesource.com/c/1262716 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#597863} [modify] https://crrev.com/703588673ea6e817e7017fcdee4a70a18342c0dd/third_party/WebKit/LayoutTests/resources/idlharness.js [modify] https://crrev.com/703588673ea6e817e7017fcdee4a70a18342c0dd/third_party/WebKit/LayoutTests/resources/testdriver.js [modify] https://crrev.com/703588673ea6e817e7017fcdee4a70a18342c0dd/third_party/WebKit/LayoutTests/resources/testharness.js
Is this fixed now?
Yep, this round is done.
Comment 1 by bugdroid1@chromium.org
, Oct 5