New issue
Advanced search Search tips

Issue 892582 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

animation style property casuses render issues on fieldset tag

Reported by edaa...@gmail.com, Oct 5

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce the problem:
1. Please check this Fiddle:

https://jsfiddle.net/fq9y50kx/

2. 
3. 

What is the expected behavior?
A normal fieldset tag.

What went wrong?
The rendered black bar in the fieldset should not be there.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 69.0.3497.100  Channel: stable
OS Version: 10.0
Flash Version:
 
Capture.PNG
723 bytes View Download

Comment 1 Deleted

Cc: flackr@chromium.org smcgruer@chromium.org
Labels: OS-Linux
Status: Available (was: Unconfirmed)
Can also reproduce on linux, and firefox can render it correctly. I tried bisecting but even the earliest version still reproduces this bug. Removing either z-index or animation makes the bug go away.
Labels: Blink-Only
Background: transparent on fieldset tag will also make the bug go away.
Note: I checked as far back as 53.0.2767.0 and this bug appears that far back. So doesn't appear to be a regression.
looking at this (no idea how to re-assigned to myself)
put a potential fix here:
https://chromium-review.googlesource.com/c/chromium/src/+/1379169/1

not really an animation bug, will email rossen/skobes to see how to re-assign this bug and who the appropriate reviewers are
Cc: tkent@chromium.org
Components: -Blink>Animation Blink>Layout
Thanks for looking into this rickj@! I believe being able to own bugs requires bug-edit privileges (https://www.chromium.org/getting-involved/get-bug-editing-privileges). I will send an email to committers@ about getting you added.

I sent your CL to the trybots for you; the presubmit will fail because you haven't signed the CLA yet, but the other bots should run and test the CL. Since the CL is in Layout, changing bug component and cc-ing tkent@ to find the appropriate reviewer.
Owner: ri...@microsoft.com
Status: Assigned (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5612ec6b2568a2b4da5444875a9fc443f1867dfd

commit 5612ec6b2568a2b4da5444875a9fc443f1867dfd
Author: Rick James <rickj@microsoft.com>
Date: Tue Dec 18 23:01:31 2018

Fixed background painting of fieldset element with a legend

The BackgroundIsKnownToBeOpaqueInRect return value contract is to return true
when there is full opaque coverage. Field set, with a legend, does not have
full coverage. Need to return false in that case.

This was leading to losing parent painting, most obvious with uninitialized
surfaces of layered parents.

Bug:  892582 
Change-Id: I8c162910d16d6d44301110146739ad1cbf9c88cd
Reviewed-on: https://chromium-review.googlesource.com/c/1379169
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617662}
[modify] https://crrev.com/5612ec6b2568a2b4da5444875a9fc443f1867dfd/AUTHORS
[modify] https://crrev.com/5612ec6b2568a2b4da5444875a9fc443f1867dfd/third_party/blink/renderer/core/layout/layout_fieldset.cc
[modify] https://crrev.com/5612ec6b2568a2b4da5444875a9fc443f1867dfd/third_party/blink/renderer/core/layout/layout_fieldset.h
[modify] https://crrev.com/5612ec6b2568a2b4da5444875a9fc443f1867dfd/third_party/blink/web_tests/TestExpectations

Status: Fixed (was: Assigned)
Should be fixed now. Thank you everyone for being so helpful in getting my first Chromium fix completed! :-)

Sign in to add a comment