Regression: [Settings] Unwanted blink of selection highlight is observed on Passphrase text box.
Reported by
db...@etouch.net,
Oct 5
|
||||||
Issue descriptionChrome Version: 71.0.3571.0 Revision b588fc0229844f0b6758d5ec481c152c891b6d9b-refs/branch-heads/3571@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS. Pre-condition: Sign in to browser which has Passphrase. What steps will reproduce the problem? (1) Launch chrome, click on Error button near to omnibox(it will navigate to chrome://settings/syncSetup page) (2) Enter invalid passphrase then click on Sumbit button,now agin enter invali passphrase and click on back navigation arrow (3) Come back to chrome://settings/syncSetup page and observe at passphrase text box. Actual: Unwanted blink of selection highlight is observed on passphrase text box. Expected: No such a blink should seen. This is a regression issue, broken in 'M71', below is bisect info: Good Build:71.0.3549.0(Revision: 590120) Bad Build: 71.0.3551.0(Revision: 590850) You are probably looking for a change made after 590307 (known good), but no later than 590358 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d70333366eb32aadb4d75cddc88fa7d76bfc3ac5..82a2dd3499e33caf58ab9dd13124d2ac8fb724b3 Suspect: https://chromium.googlesource.com/chromium/src/+/54a733daaab037e63fe5474be68c6e5877c9c670 @stevenjb: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to provide 'per-revision' bisect as it shows "[Error 5] Access denied" error message for above range. (tried on other machines but still getting the same error again) 2. Hence provided suspect through 'Chromium bisect'.
,
Oct 5
See [1] and [2]. @hcarmona: Is there a way to override that logic for a certain subpage? [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/settings_subpage.js?l=84 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/settings_animated_pages.js?l=68
,
Oct 5
We haven't needed to add an exception yet, we might be able to just add a boolean no-focus property and check if it's set when we're about to focus and skip if necessary.
,
Oct 11
Minor artifact, -> P2
,
Oct 30
,
Dec 3
,
Dec 10
Since this isn't CrOS specific, and Settings page navigation was never my area of expertise, I am unassigning it and putting it into the avaiable pool. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Oct 5