New issue
Advanced search Search tips

Issue 892562 link

Starred by 3 users
Status: Fixed
Owner:
jarhar@chromium.org
Closed: Jan 4
Cc:
binghamj@chromium.org
phanindra.mandapaka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AppCache viewer in DevTools broken in M70

Project Member Reported by pwnall@chromium.org, Oct 5 
What steps will reproduce the problem?
(1) Go to https://archive.jonathanstark.com/labs/app-cache-2b/ or any other https site that uses AppCache
(2) Open DevTools and go to the Application tab
(3) Click "Application Cache" on the left sidebar, under "Cache"

What is the expected result?

On M69, there is a dropdrown next to "Application Cache". It shows the manifest used and cached resources.

What happens instead?

On M70 and M71, there is no dropdown, and clicking "Application Cache" does nothing.

Note that clicking on "Clear Storage" shows quota usage, so DevTools is aware of the quota change due to AppCache use.



Please use labels and text to provide additional information.

Setting to P2 because we recommend modern applications to use Service Worker instead of AppCache.

If the code has bit-rotted and there aren't resources to fix it, I'd be fine with removing the AppCache view from DevTools altogether. That seems better than the current state, which suggests no AppCache is active.

Comment 1 by pwnall@chromium.org, Jan 2 

Alternative reproduction:

1) Enable Offline support for Google Docs -- https://docs.google.com/offline/optindialog guides through the steps.

2) Navigate to https://docs.google.com

3) Open DevTools. 
3a) Check "Application > Clear storage"
3b) Check "Cache > Application Cache"

Once Docs Offline populates the cache, "Clear storage" shows non-zero AppCache usage. The Application Cache panel shows nothing.

Comment 2 by binghamj@chromium.org, Jan 2

Cc: binghamj@chromium.org
Components: -Platform>Apps>DevTools Platform>DevTools
Owner: jarhar@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82cbd9682a79279d3399ace1859c1abd55802ee5

commit 82cbd9682a79279d3399ace1859c1abd55802ee5
Author: Joey Arhar <jarhar@chromium.org>
Date: Fri Jan 04 23:23:38 2019

[DevTools] Fix AppCache viewer

window.applicationCache isn't available within DevTools after
http://crrev.com/c/1160644/ so we can't use it for status constants.

Bug:  892562 
Change-Id: Icbd33c345003595f090558fdb2ce7312f54ba93a
Reviewed-on: https://chromium-review.googlesource.com/c/1396615
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620101}
[modify] https://crrev.com/82cbd9682a79279d3399ace1859c1abd55802ee5/third_party/blink/renderer/devtools/front_end/resources/ApplicationCacheItemsView.js
[modify] https://crrev.com/82cbd9682a79279d3399ace1859c1abd55802ee5/third_party/blink/renderer/devtools/front_end/resources/ApplicationCacheModel.js

Comment 5 by jarhar@chromium.org, Jan 4

Status: Fixed (was: Assigned)

Comment 6 by phanindra.mandapaka@chromium.org, Jan 7

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M73 TE-Verified-73.0.3664.0
Able to reproduce this issue on Mac OS 10.14 on the build without Fix 71.0.3573.0 and the issue is fixed on the latest M-73 build 73.0.3664.0.

1. Launched Chrome 
2. Opened given url "https://archive.jonathanstark.com/labs/app-cache-2b/ "
3. Opened Devtools > Application Tab > Cache 
Observed there is a drop down next to the "Application Cache"
Attached is the screen shot for reference. Hence adding TE verified labels.

Thanks..!
892562.mp4
1.3 MB View Download
►

Sign in to add a comment