No gap is seen between 'Remove' and 'Cancel' button on 'Add shortcut' overlay.
Reported by
aiman.an...@etouch.net,
Oct 5
|
||||||
Issue descriptionChrome Version: 71.0.3571.0 (Official Build) Revision b588fc0229844f0b6758d5ec481c152c891b6d9b-refs/branch-heads/3571@{#1} (32/64 Bit). OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS. Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags and relaunch the browser. What steps will reproduce the problem? 1. Open NTP, navigate to 'chrome://settings/fonts' and change Minimum font size to 'Huge'. 2. Navigate to NTP, click on 'Add Shortcut' link to open the Add shortcut overlay. 3. Observe 'Remove' and 'Cancel' button. Actual Result: No gap is seen between 'Remove' and 'Cancel' button on 'Add shortcut' overlay. Expected Result: Proper gap should be seen between 'Remove' and 'Cancel' button on 'Add shortcut' overlay. This is Non-Regression issue seen from ‘M-70’ from build #70.0.3504.0, as 'Add shortcut' option was introduced on NTP. Kindly review the attached screen-cast for reference. Thank you..!!
,
Oct 5
,
Oct 8
,
Oct 8
,
Oct 8
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf11f33c7f684df81f9d9b89cd6ff25eb8273b5e commit bf11f33c7f684df81f9d9b89cd6ff25eb8273b5e Author: Kristi Park <kristipark@chromium.org> Date: Tue Oct 09 00:18:19 2018 [NTP] Add gap between button groups in the edit custom link dialog Screenshot: https://screenshot.googleplex.com/jNZt2dsqAJq.png Bug: 892555 Change-Id: Ib9beb6616f8353196a5cc797e0ad699b90218e28 Reviewed-on: https://chromium-review.googlesource.com/c/1269803 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597748} [modify] https://crrev.com/bf11f33c7f684df81f9d9b89cd6ff25eb8273b5e/chrome/browser/resources/local_ntp/custom_links_edit.css
,
Oct 9
,
Oct 10
Hi, Retested the above issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS using latest Canary build #71.0.3575.0 and issue is fixed. Proper gap is seen between Remove and Cancel button. Kindly refer the attached screen-cast. Thank You! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by aiman.an...@etouch.net
, Oct 5