Issue metadata
Sign in to add a comment
|
Application Cache size is limited to 5MB
Reported by
eldo...@gmail.com,
Oct 5
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: 1. Load fail.html 2. The browser tries to load the 6 files of about 1MB specified in the fail.appcache manifest 3. The storage commit fails due to quota exceed What is the expected behavior? The commit succeeds. What went wrong? The commit fails saying it would exceed quota. You can try success.html, which loads just 5 of the files in the manifest, remaining under 5MB of total size, and it will succeed. Did this work before? Yes 70 Does this work in other browsers? Yes Chrome version: 71.0.3570.0 Channel: canary OS Version: 10.0 Flash Version:
,
Oct 5
The bug does not reproduce on 70.0.3538.45 on Mac, so it is a regression introduced in M71. The AppCache tab in DevTools does not update in M70, so that error is unrelated to this bug.
,
Oct 5
Filed https://crbug.com/892562 to track the DevTools issue.
,
Oct 6
The root cause is https://crrev.com/c/1203752 At a high level, the approach in https://crbug.com/824619 seems unfortunate. The bug doesn't have a component (Blink>Storage>AppCache and Blink>StorageQuota come to mind), so it didn't show on our radar. The work introduced a non-trivial AppCache change without adding tests, and without consulting the Storage team. Asides from causing this bug, the approach is most likely incorrect -- reducing disk storage limits is best accomplished in Quota Manager, where the behavior change would apply to all storage APIs. We're close to branch point, and I think the best path forward is to revert the changes in https://crrev.com/c/1203752 before M71 branches. I'd like to figure out another AppCache crasher before branch point, so I won't have time to explore a better fix. After the branch, we can figure out how to best meet the needs behind the feature. gyuyoung.kim@: Please reach out to me (pwnall@chromium.org) over the next few days if you need this in M71.
,
Oct 9
Haven't heard anything, going to start reverting the CLs here.
,
Oct 9
The root cause was reverted in https://crrev.com/c/1271879
,
Oct 10
@pwnall, Sorry for late response. I was on a business trip by yesterday. Once I'm going to check what code caused the issue. Thanks and sorry for the inconvenience.
,
Oct 10
gyuyoung.kim@lge.com: No worries. Let's discuss in https://crbug.com/824619 to find a way to get your needs met.
,
Oct 11
,
Oct 11
Checked that the bug does not repro in today's Canary -- 71.0.3576.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pwnall@chromium.org
, Oct 5Labels: -Pri-2 OS-Mac Pri-1
Owner: pwnall@chromium.org
Status: Assigned (was: Unconfirmed)