Flaky test: GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=405bcc0fbf80bc10 Test output log: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8178 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I6fc9a4eb218231781325ba7a5af992b12610b929 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKCAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzgxNzgvdml6X2Jyb3dzZXJfdGVzdHMvUjJGc2JHVnllVUp5YjNkelpYSlVaWE4wTGtSbGJHVjBaVk5wYm1kc1pVOXdaVzVRYUc5MGIwOXVSRzkzYm14dllXUnoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKCAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzgxNzgvdml6X2Jyb3dzZXJfdGVzdHMvUjJGc2JHVnllVUp5YjNkelpYSlVaWE4wTGtSbGJHVjBaVk5wYm1kc1pVOXdaVzVRYUc5MGIwOXVSRzkzYm14dllXUnoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b7961c27546973db0292d9d3d373a1d19eb2aa9 commit 9b7961c27546973db0292d9d3d373a1d19eb2aa9 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Oct 05 08:18:01 2018 Revert "Hide filename edit field when there is no image" This reverts commit d270ec3902afe58988234832b7c33f7e5ce92aa6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596972 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDI3MGVjMzkwMmFmZTU4OTg4MjM0ODMyYjdjMzNmN2U1Y2U5MmFhNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8178 Sample Failed Step: viz_browser_tests Sample Flaky Test: GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads Original change's description: > Hide filename edit field when there is no image > > Hide |filenameEdit_| line edit box when there is no image to be displayed. > This fixes an undesired grey line appearing as the bottom of this edit box. > Changing the "disabled" state doesn't change the style of this box, > "disabled" state is only used for read-only behaviour not style. > > R=fukino@chromium.org > > Bug: 796503 > Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929 > Reviewed-on: https://chromium-review.googlesource.com/c/1212263 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Alexander Nohe <nohe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596972} Change-Id: I5a64c57351cc39d641af6052567c8f8d150542cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796503 , 892543 Reviewed-on: https://chromium-review.googlesource.com/c/1263887 Cr-Commit-Position: refs/heads/master@{#597033} [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/gallery/js/gallery.js [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/integration_tests/gallery/open_image_files.js [modify] https://crrev.com/9b7961c27546973db0292d9d3d373a1d19eb2aa9/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
Findit auto-reverted the CL, so I'm removing this from the sheriffs' queue.
Comment 1 by bugdroid1@chromium.org
, Oct 5