Flaky test: NetworkServiceRestartBrowserTest.SharedWorker Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=405bbf9fd72f7e10 Test output log: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14262 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Iab8864d673da04cea062f65644e2ee10f74de4da Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0MjYyL3NpbmdsZV9wcm9jZXNzX21hc2hfY29udGVudF9icm93c2VydGVzdHMvVG1WMGQyOXlhMU5sY25acFkyVlNaWE4wWVhKMFFuSnZkM05sY2xSbGMzUXVVMmhoY21Wa1YyOXlhMlZ5DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20NetworkServiceRestartBrowserTest.SharedWorker&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0MjYyL3NpbmdsZV9wcm9jZXNzX21hc2hfY29udGVudF9icm93c2VydGVzdHMvVG1WMGQyOXlhMU5sY25acFkyVlNaWE4wWVhKMFFuSnZkM05sY2xSbGMzUXVVMmhoY21Wa1YyOXlhMlZ5DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0f7c620bf6690d257bca4e094e81fe7096f1a83 commit c0f7c620bf6690d257bca4e094e81fe7096f1a83 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Oct 05 07:14:23 2018 Revert "shared worker: Self-terminate when network service crashes." This reverts commit 24c77b16ea86fa02df8b8b0eb45a120cf02dc879. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596999 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjRjNzdiMTZlYTg2ZmEwMmRmOGI4YjBlYjQ1YTEyMGNmMDJkYzg3OQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14262 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: NetworkServiceRestartBrowserTest.SharedWorker Original change's description: > shared worker: Self-terminate when network service crashes. > > This treats the network service crashing like the worker's process > crashing, and prevents clients getting stuck with a broken worker. > > Bug: 848256 > Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da > Reviewed-on: https://chromium-review.googlesource.com/c/1260903 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596999} Change-Id: I2bf5229056da67f539f4f89ed7fc92578edac567 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848256 , 892535 Reviewed-on: https://chromium-review.googlesource.com/c/1263885 Cr-Commit-Position: refs/heads/master@{#597020} [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/browser/network_service_restart_browsertest.cc [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/c0f7c620bf6690d257bca4e094e81fe7096f1a83/content/renderer/shared_worker/embedded_shared_worker_stub.h
Comment 1 by bugdroid1@chromium.org
, Oct 5