Let RevertDrag() handle the merge-back-to-source-window case |
||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Chrome It's a comment from the CL review https://chromium-review.googlesource.com/c/chromium/src/+/1259468/. When a tab dragging process is ended, sometimes we need to merge the dragged window back into the source window. Currently we're setting the kIsDeferredTabDraggingTargetWindowKey property on the source window from ash side to inform chrome to do proper merge-back when drag ends. We should consider to use RevertDrag() directly for this case. To do this, ClearTabDraggingInfo() should be moved to a later point after CompleteDrag() or RevertDrag() is called.
,
Oct 19
As RevertDrag() guaranteed the dragged tab(s) merges back into its (their) original position, I think it's worthy a merge-back to M71.
,
Oct 20
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20
This change impacts a number of areas. Can you add context to verify all is working and low risk? Thanks
,
Oct 22
Although this CL touched many files, it should be safe to merge back. The reason I requested a merge-back is this CL also fixed a merge-back behavior. Before this CL, if a tab is dragged out from a window, but is not dragged long enough (more than half of the screen height), the tab will be merged back into the window, but is always merged back to the first tab of the window. After this CL, the tab will be merged back to its original position of the window.
,
Oct 22
Safe meaning it was tested? Need to evaluate risk on the test results. Thanks
,
Oct 22
I tested it on my device and also all unittests were passed. No tester has verified the issue yet. Anyway, I don't have strong preference to merge it back. If you feel it's risky, I can just keep it in M72.
,
Oct 23
Since it's a P2 let's push to M72, unless you have broad test coverage and consider low risk. Declining the merge; feel free to re-request if this escalates. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 19