New issue
Advanced search Search tips

Issue 892500 link

Starred by 1 user
Status: Fixed
Owner:
yosin@chromium.org
Closed: Oct 10
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 887148



Sign in to add a comment

Element.innerText emits block's trailing space if it follows <input>

Project Member Reported by xiaoche...@chromium.org, Oct 5 
Chrome Version: ToT @ r596952
OS: Linux

What steps will reproduce the problem?
(1) Use "data:text/html, <input> <div>foo</div>"
(2) Open console and get document.body.innerText value

What is the expected result?

Should get "foo"

What happens instead?

Got " foo" instead

Looks like a regression by crrev.com/c/1250825, as it doesn't repro in M71 Dev (71.0.3569.0)

Comment 1 by xiaoche...@chromium.org, Oct 5

Blocking: 887148
This is found when trying to use innerText as text dump for compositing/contents-opaque/control-layer.html.

Let's not check in incorrect baselines.

Comment 2 by yosin@chromium.org, Oct 5

Status: Started (was: Assigned)
In review: http://crrev.com/c/1264339
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc124c8111b278045f0e8e031e4bce10dafad2df

commit cc124c8111b278045f0e8e031e4bce10dafad2df
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Oct 09 11:24:55 2018

Make Element#innerText not to emit a space after inline-block and before block

This patch makes Element#innerText not to emit a space after inline-block and
before block for improving interop.

This patch fixes regression caused by the patch[1].

[1] http://crrev.com/c/1250825 Make Element#innerText to not collapse white
space around inline-block

Bug:  892500 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4343c0d74f3445263a209697aaf3c24aef82a900
Reviewed-on: https://chromium-review.googlesource.com/c/1264339
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597879}
[modify] https://crrev.com/cc124c8111b278045f0e8e031e4bce10dafad2df/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
[modify] https://crrev.com/cc124c8111b278045f0e8e031e4bce10dafad2df/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-tests.js
[modify] https://crrev.com/cc124c8111b278045f0e8e031e4bce10dafad2df/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
[modify] https://crrev.com/cc124c8111b278045f0e8e031e4bce10dafad2df/third_party/blink/renderer/core/editing/element_inner_text.cc

Comment 4 by yosin@chromium.org, Oct 10

Status: Fixed (was: Started)
►

Sign in to add a comment