New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892494 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment

Expose WKWebView.allowsBackForwardNavigationGestures from //ios/web_view

Project Member Reported by ichikawa@chromium.org, Oct 5

Issue description

I won't turn it on for Chrome because it causes an issue that it sometimes falls back to Chrome's navigation gesture unexpectedly per danyao@.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823

commit 97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Thu Oct 11 03:21:21 2018

Add CWVWebView.allowsBackForwardNavigationGestures.

BUG= 892494 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib7ba403e88321b645f9e0deaf6a33d2d964c6cce
Reviewed-on: https://chromium-review.googlesource.com/c/1010042
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598652}
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/public/web_state/ui/crw_web_view_proxy.h
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/web_state/ui/crw_web_view_proxy_impl.mm
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web/web_state/ui/crw_web_view_proxy_impl_unittest.mm
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/97f4bd65a69a2e1cc9bfde2ed8a298e2812f2823/ios/web_view/public/cwv_web_view.h

Status: Fixed (was: Started)

Sign in to add a comment