New issue
Advanced search Search tips

Issue 892488 link

Starred by 1 user
Status: Assigned
Owner:
ajp@chromium.org
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

I sometimes get 503s during git cl upload

Project Member Reported by fergal@chromium.org, Oct 5 
Spawning this off from https://crbug.com/887712

I feel like I see this quite a bit recently (and never before maybe 2/3 weeks ago). I think I've also seen some 404s, it's a bit of mix and I can't really say what ratio.

What should I upload to help with this? Here's the cli output that I saw

-----------

$@ git cl upload -m'remove old per-file owners'
Running presubmit upload checks ...

Presubmit checks took 31.0s to calculate.

Presubmit checks passed.
 third_party/blink/PRESUBMIT.py                      |  3 ++-
 third_party/blink/tools/OWNERS                      |  4 ---
 third_party/blink/tools/blinkpy/presubmit/OWNERS    |  3 +++
 .../blink/tools/blinkpy/presubmit/__init__.py       |  3 +++
 .../presubmit}/audit_non_blink_usage.py             |  0
 .../blinkpy/presubmit/audit_non_blink_usage_test.py | 30 ++++++++++++++++++++++
 6 files changed, 38 insertions(+), 5 deletions(-)

saving CL description to /usr/local/google/home/fergal/.git_cl_description_backup

remote: Processing changes: refs: 1, updated: 1, done
remote: commit 8b57232: warning: subject >50 characters; use shorter first paragraph
remote:
remote: SUCCESS
remote:
remote: Updated Changes:
remote:   https://chromium-review.googlesource.com/c/chromium/src/+/1261103 Move audit_non_blink_usage.py to blinkpy and add test.
remote:
To https://chromium.googlesource.com/chromium/src.git
 * [new branch]                8b57232cf411f9b64dea779f8deb3c8c50bbf7c5 -> refs/for/refs/heads/master%notify=NONE,m=remove_old_per%2Dfile_owners
WARNING:root:A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/chromium%2Fsrc~1261103/revisions/current/review HTTP/1.1
HTTP/1.1 503 Service Unavailable
WARNING:root:A transient error occurred while querying chromium-review.googlesource.com:
POST https://chromium-review.googlesource.com/a/changes/chromium%2Fsrc~1261103/revisions/current/review HTTP/1.1
HTTP/1.1 503 Service Unavailable

Comment 1 by ajp@chromium.org, Oct 5 

Thanks for the report! Based on this command line output, I think the fix we're doing for https://crbug.com/881860 will fix this problem for Chromium. It looks like the initial git push is succeeding and creating a change, but then subsequent POST requests are failing. This should work (and Gerrit team agrees on that). I also agree that 404 and 503 may be separate bugs.

On the good side, the solution we're going with for bug 881860 is to remove the subsequent POST requests altogether and do everything in the git push that is succeeding. That's why I suspect from our end things will work as we fix bug 881860. No POSTs hopefully no problem.

That won't, however, mean that whatever is wrong on the Gerrit side has been fixed. We'll just be avoiding the problem. Let me raise this issue with the Gerrit team, see if they know anything about it, and ask how we can help debug.

Comment 2 by ajp@chromium.org, Oct 5 

Filed to Gerrit as http://b/117337276 (Sorry, Google only).

Looking at Gerrit's bug template information that could be useful in the future:

output of "which git && git --version"
Timestamp when the error occurred (include timezone)

Comment 3 by jojwang@google.com, Oct 9

Description: Show this description

Comment 4 by ajp@chromium.org, Oct 15

Status: Assigned (was: Untriaged)
►

Sign in to add a comment