Issue metadata
Sign in to add a comment
|
SignIn for sometimes Smart Lock doesn't work until unlock with SL has been performed |
||||||||||||||||||||||||
Issue descriptionRepro: 1) Go through multidevice setup 2) Go to Smart Lock settings, and enable Signin for Smart Lock 3) Sign out and observe The Smart Lock icon has changed to a grey icon with a dotted circle around it, and the tooltip reads "Enter your password to turn on Smart Lock. Next time, your phone will unlock your Chromebook...". This string is either wrong or confusing for a couple reasons: A) I just went through multidevice setup. Why do I need to "turn on Smart Lock" if I just did so? B) Entering my password doesn't do anything to change this state. If I do so and then sign out again, I see this message again. re: B) the only way to enable Signin for Smart Lock is to signin via password, lock the screen and go through Smart Lock on the lock screen. Is this intended? If so, we need to change the string to appropriately inform the user of what they need to do. However, I'd actually prefer if we changed this behavior such that Signin for Smart Lock immediately works after enabling it in Settings. Shiba, I'm curious to hear your thoughts here on how you think this should behave.
,
Oct 5
A) Makes sense - Can we replace 'turn on' with 'enable' in the string? B) Is this a bug?
,
Oct 5
Isn't this a dupe of issue 848893?
,
Oct 5
- re: my initial report, I've confirmed with James offthread that requiring the user to enter their password on the sign-in screen the first time is expected behavior. - re: #1: Yes, I'm certain. Please see my revised repro steps below. - re: #2, A: Let's track this in a separate, lower priority bug, since that particular string is expected behavior and not related to this issue: crbug.com/892698 . Some corrections to my original report: To repro this 100% of the time: 1) Sign user out, and sign back in (and enable the multidevice flags -- this bug only affects the new multidevice "world", explained more below). 2) Go through multidevice setup flow. 3) Go to Smart Lock settings and enable Signin for Smart Lock 4) Sign out: the text reads ""Enter your password to turn on Smart Lock..." This is expected behavior. 5) Sign in. 6) Sign out again: the text now reads: "Smart Lock phone changed. Enter your password to update Smart Lock..." [1]. This is unexpected behavior. You can repeat steps 5 and 6 forever -- it will always be stuck in the state of "Smart Lock phone changed". The only thing that prevents this state, and gets the device out of state when it's in it, is going through Smart Lock on the lock screen. This bug seems to have never been an issue before multidevice because the old Smart Lock flow prompted the user to "Try Smart Lock" as soon as they set it up. 1) https://cs.chromium.org/chromium/src/chrome/app/chromeos_strings.grdp?q=%22Smart+Lock+phone+changed%22&sq=package:chromium&g=0&l=4092
,
Oct 5
James and I agree that this shouldn't be a launch blocker for multidevice launch, so I'm removing it from the hotlist.
,
Oct 5
re: #3: No, this is not a dupe of crbug.com/848893.
,
Oct 9
,
Oct 9
,
Oct 9
,
Oct 13
,
Jan 17
(5 days ago)
Just hit this issue again while writing E2E tests, but with a subtly different behavior. See crbug.com/923152. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jhawkins@chromium.org
, Oct 5