New issue
Advanced search Search tips

Issue 892480 link

Starred by 7 users
Status: Fixed
Owner:
rsesek@chromium.org
Closed: Oct 18
Cc:
erikc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"Hide Others" lacks Cmd+Opt+H shortcut

Reported by jleedev@gmail.com, Oct 5 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3570.0 Safari/537.36

Steps to reproduce the problem:
1. Press Command+Option+H
2. Look at "Hide Others" in the menu bar

What is the expected behavior?

What went wrong?
Shortcut is missing

Did this work before? Yes 

Chrome version: 71.0.3570.0  Channel: canary
OS Version: OS X 10.14.0
Flash Version: 

You are probably looking for a change made after 577645 (known good), but no later than 577678 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/977027b71da984e469efb76c378d36b6a8ae5d03..a2c9ffdd41e6037a073d5403ede40cbbbee2313f

Comment 1 by swarnasree.mukkala@chromium.org, Oct 5

Labels: Needs-Bisect Needs-Triage-M71

Comment 2 by krajshree@chromium.org, Oct 5

Cc: erikc...@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET RegressedIn-70 Target-70 Target-71 M-70 FoundIn-71 FoundIn-70 Pri-1
Owner: rsesek@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on mac 10.13.3 using chrome reported version #71.0.3570.0. Issue is specific to OS-Mac.

Bisect Information:
=====================
Good build: 70.0.3501.0
Bad Build : 70.0.3502.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/61c2840f00243135c7f22504ba0d8147db68b856..124f80f9c6f0935ed1369617346443d4321427bf

From the above change log suspecting below change
Change-Id: I1c8ebdff45a92d4aee0f2a8b253274c03a76611c
Reviewed-on: https://chromium-review.googlesource.com/1147157

rsesek@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-70 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.
ccing the reviewer of the issue as the owner of the issue seems to be OOO till 8th Oct.

Thanks...!!

Comment 3 by ellyjo...@chromium.org, Oct 5

Labels: -Pri-1 -ReleaseBlock-Stable -Target-70 -M-70 M-71 Pri-2
Mac triage: stripping RBS, targeting M71.

Comment 4 by rsesek@chromium.org, Oct 18

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6b04d44ac52363e6e670b7f39ea890bcbf22a67

commit b6b04d44ac52363e6e670b7f39ea890bcbf22a67
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Oct 18 19:04:49 2018

mac: Restore the "Hide Other" main menu shortcut.

Also ensure Hide Others and Show All are in the PWA menus.

Bug:  892480 
Change-Id: I507771745c95203fda8344703c7b1b015a93699a
Reviewed-on: https://chromium-review.googlesource.com/c/1288851
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600851}
[modify] https://crrev.com/b6b04d44ac52363e6e670b7f39ea890bcbf22a67/chrome/browser/ui/cocoa/main_menu_builder.mm

Comment 6 by rsesek@chromium.org, Oct 18

Labels: -M-71 M-72
Status: Fixed (was: Started)
Didn't make M71 unfortunately. If this is really affecting your workflow, you can temporarily assign the shortcut in System Preferences > Keyboard.

Comment 7 by rsesek@chromium.org, Dec 1 

 Issue 910761  has been merged into this issue.

Comment 8 by rsesek@chromium.org, Dec 10 

 Issue 913365  has been merged into this issue.
►

Sign in to add a comment