netlog_viewer should load faster |
|||
Issue descriptionhttps://netlog-viewer.appspot.com/, being a Polymer app, should go through the typical build steps to optimize for production. Like Vulkanize to flatten the zillions of imports, and some code minification steps.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/20741eb7e510af336cb2083bff114f6666ea6227 commit 20741eb7e510af336cb2083bff114f6666ea6227 Author: Matt Mueller <mattm@chromium.org> Date: Fri Nov 02 23:56:17 2018 netlog_viewer: fix top-bar-view id conflict The conflict causes problems when the app is vulcanized. NOPRESUBMIT=true Bug: chromium:892466 Change-Id: I909b4d17933930d21851dfbcff66eae8940b9b4e Reviewed-on: https://chromium-review.googlesource.com/c/1313259 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> [modify] https://crrev.com/20741eb7e510af336cb2083bff114f6666ea6227/netlog_viewer/netlog_viewer/tab_views.css [modify] https://crrev.com/20741eb7e510af336cb2083bff114f6666ea6227/netlog_viewer/netlog_viewer/top_bar_view.js [modify] https://crrev.com/20741eb7e510af336cb2083bff114f6666ea6227/netlog_viewer/netlog_viewer/top_bar_view.html
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489 commit 8c035b35abf8db181ae20d6e3a1f0e4c30c9f489 Author: Matt Mueller <mattm@chromium.org> Date: Sat Nov 03 00:41:04 2018 netlog_viewer: Remove external resource loading, vulcanize for appspot. NOPRESUBMIT=true Bug: chromium:892459 , chromium:892466 Change-Id: I0e5910af646b94cc61bfee533ef2ee51cebc730c Reviewed-on: https://chromium-review.googlesource.com/c/1313260 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> [add] https://crrev.com/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489/netlog_viewer/netlog_viewer_build/build_for_appengine.py [modify] https://crrev.com/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489/netlog_viewer/README.md [modify] https://crrev.com/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489/netlog_viewer/appengine/app.yaml [modify] https://crrev.com/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489/netlog_viewer/netlog_viewer/index.html [modify] https://crrev.com/8c035b35abf8db181ae20d6e3a1f0e4c30c9f489/netlog_viewer/netlog_viewer/tests.html
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/819fcfd32477b6d9a9df3adf61a764cd0e96d656 commit 819fcfd32477b6d9a9df3adf61a764cd0e96d656 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Nov 03 03:47:44 2018 Roll src/third_party/catapult c02ed04700f7..8c035b35abf8 (4 commits) https://chromium.googlesource.com/catapult.git/+log/c02ed04700f7..8c035b35abf8 git log c02ed04700f7..8c035b35abf8 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mattm@chromium.org netlog_viewer: Remove external resource loading, vulcanize for appspot. 2018-11-02 mattm@chromium.org netlog_viewer: fix top-bar-view id conflict 2018-11-02 mattm@chromium.org netlog_viewer: load polyfills so it continues to work after upcoming deprecations 2018-11-02 mattm@chromium.org netlog_viewer: remove unused styles Created with: gclient setdep -r src/third_party/catapult@8c035b35abf8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:892459 , chromium:892466 , chromium:892466 TBR=sullivan@chromium.org Change-Id: Iecf0b62b7de0626dbc3bf6c8bd27a219495720be Reviewed-on: https://chromium-review.googlesource.com/c/1316851 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605145} [modify] https://crrev.com/819fcfd32477b6d9a9df3adf61a764cd0e96d656/DEPS
,
Nov 7
It's now vulcanized, but not minified. It does load much faster now though, so I don't have any immediate plans to do more.
,
Nov 7
I consider the original bug now fixed. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by mattm@chromium.org
, Oct 20Status: Started (was: Untriaged)