New issue
Advanced search Search tips

Issue 892459 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

netlog_viewer should not include any cross origin resources

Project Member Reported by eroman@chromium.org, Oct 5

Issue description

https://netlog-viewer.appspot.com/ currently includes polymer by importing from https://polygit.org/.

It should only include its own scripts and resources.

There is a TODO about removing this (which no longer applies).

 
Cc: -mattm@chromium.org
Owner: mattm@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/819fcfd32477b6d9a9df3adf61a764cd0e96d656

commit 819fcfd32477b6d9a9df3adf61a764cd0e96d656
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Nov 03 03:47:44 2018

Roll src/third_party/catapult c02ed04700f7..8c035b35abf8 (4 commits)

https://chromium.googlesource.com/catapult.git/+log/c02ed04700f7..8c035b35abf8


git log c02ed04700f7..8c035b35abf8 --date=short --no-merges --format='%ad %ae %s'
2018-11-03 mattm@chromium.org netlog_viewer: Remove external resource loading, vulcanize for appspot.
2018-11-02 mattm@chromium.org netlog_viewer: fix top-bar-view id conflict
2018-11-02 mattm@chromium.org netlog_viewer: load polyfills so it continues to work after upcoming deprecations
2018-11-02 mattm@chromium.org netlog_viewer: remove unused styles


Created with:
  gclient setdep -r src/third_party/catapult@8c035b35abf8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:892459 , chromium:892466 , chromium:892466 
TBR=sullivan@chromium.org

Change-Id: Iecf0b62b7de0626dbc3bf6c8bd27a219495720be
Reviewed-on: https://chromium-review.googlesource.com/c/1316851
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605145}
[modify] https://crrev.com/819fcfd32477b6d9a9df3adf61a764cd0e96d656/DEPS

Status: Fixed (was: Started)

Sign in to add a comment