Remove obsolete commands from the modem script |
|||
Issue descriptionRemove the following obsolete commands from the modem script: ciprl-update get-oma-status get-prl get-service start-oma update-prl
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f9c1fd27515987eb2a12532a148b08dae5ad8846 commit f9c1fd27515987eb2a12532a148b08dae5ad8846 Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 05 22:42:59 2018 modem-utilities: remove obsolete commands from 'modem' script BUG= chromium:892455 TEST=Tested remaining modem commands such as 'modem status'. Change-Id: I1b678aa3dc82f3cb24e37c27faa05ef83910d39f Reviewed-on: https://chromium-review.googlesource.com/1262881 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f9c1fd27515987eb2a12532a148b08dae5ad8846/modem-utilities/modem
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d5fa9c2fde46409c8929647c7334b7aade6ebd9c commit d5fa9c2fde46409c8929647c7334b7aade6ebd9c Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 05 22:43:00 2018 debugd: remove org.chromium.debugd.RunModemCommand D-Bus API The org.chromium.debugd.RunModemCommand D-Bus API was used by the 'modem' script to send AT commands to some old modems that we supported, which are not longer supported or needed. CL:1262881 removed those commands from the modem script. This CL removes the org.chromium.debugd.RunModemCommand D-Bus API from debugd as well as the send_at_command.sh helper script. BUG= chromium:892455 CQ-DEPEND=CL:1263178 TEST=Verify that org.chromium.debugd.RunModemCommand no longer exists. Change-Id: I3ad2a5999e7d02f19fd19e3c66f453d0a3e20042 Reviewed-on: https://chromium-review.googlesource.com/1262882 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/f9c1fd27515987eb2a12532a148b08dae5ad8846/debugd/src/modem_status_tool_test.cc [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/src/debugd_dbus_adaptor.cc [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/src/modem_status_tool.h [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/src/debugd_dbus_adaptor.h [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/src/modem_status_tool.cc [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/dbus_bindings/org.chromium.debugd.xml [modify] https://crrev.com/d5fa9c2fde46409c8929647c7334b7aade6ebd9c/debugd/debugd.gyp [delete] https://crrev.com/f9c1fd27515987eb2a12532a148b08dae5ad8846/debugd/src/helpers/send_at_command.sh
,
Oct 5
,
Dec 3
Modem script now has below options: localhost ~ # modem Missing argument: cmd Usage: modem <command> [args...] activate [-modem <modem>] [<carrier>] Activate modem activate-manual [-modem <modem>] [args...] Activate modem manually connect [-modem <modem>] [phone number] Connect modem factory-reset [-modem <modem>] [<spc>] Factory-reset the modem reset [-modem <modem>] Reset the modem set-carrier [-modem <modem>] <carrier-name> Set modem carrier firmware set-logging (debug|info|warn|error) Set logging level set-madison-config <config-group-name> Set Madison config group status Display modem status ussd [-modem <modem>] status Show status of ongoing USSD session ussd [-modem <modem>] initiate <command> Initiate a USSD session ussd [-modem <modem>] respond <response> Respond to a USSD request ussd [-modem <modem>] cancel Cancel ongoing USSD session Below options are removed: ciprl-update get-oma-status get-prl get-service start-oma update-prl |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 5