SpellChecker: false positive "OpenIn -> Opening" |
|||||
Issue descriptionhttps://tricium-prod.appspot.com/run/6316848534519808 Probably it should detect that there is no white spaces on either side of the word.
,
Oct 5
Thanks for the report, good point. CL link: https://chromium-review.googlesource.com/c/chromium/src/+/1259295/5/ios/chrome/browser/ui/open_in_controller.h#20 Expected behavior: Words written in CamelCase should be parsed as separate words, e.g. ThisSequenceOfWords is like "this sequence of words". OpenIn is like "open in" Actual behavior: Words are split on non-word characters, and then lower-cased before checking the dictionary (for case-insensitivity), so when we see IOS.OpenIn.DownloadResult we check for "ios", "openin" and "downloadresult". (Instead we could perhaps check "open", "in", "download", "result"). Quick fix to avoid false positives like this: just don't check camel-case words. We already skip all-caps words. Better fix: when checking a word, if it is camel-case, split it into multiple parts and check individual parts.
,
Nov 20
,
Nov 22
I would like to fix this one. I'll do it the splitting way :)
,
Nov 26
Awesome! [Note, again I still can't officially assign an issue to you since you're not officially a "project member" yet. I tried to find out what's needed to be nominated as a project member, and I didn't find a clear answer, although presumably if you want to continue contributing patches to Chromium, then later on you could be nominated as a committer (https://www.chromium.org/getting-involved/become-a-committer), at which point you should definitely be considered a "project member".]
,
Nov 28
Becoming an official project member sounds awesome! :) I still need to know more about Tricium though.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/68ec8b8d51ad6efa883518b7b4ad7c035a05c395 commit 68ec8b8d51ad6efa883518b7b4ad7c035a05c395 Author: Parminder Singh <parmsingh129@gmail.com> Date: Sat Dec 01 00:40:06 2018 Handle Camelcase in comments The comment words that are in camelcase i.e. contain uppercase letter inside word, will be broken into segments and checked individually. OpenIn becomes [Open, In] camelCaseExample becomes [camel, Case, Example] Also added unit tests and verified it doesn't break any previous tests. Bug: 892449 Change-Id: I589155383e4b67bb91262fba832b61eb1a1cca27 Reviewed-on: https://chromium-review.googlesource.com/c/1353014 Auto-Submit: Parminder Singh <parmsingh129@gmail.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#19284} [modify] https://crrev.com/68ec8b8d51ad6efa883518b7b4ad7c035a05c395/go/src/infra/tricium/functions/spellchecker/spellchecker_test.go [modify] https://crrev.com/68ec8b8d51ad6efa883518b7b4ad7c035a05c395/go/src/infra/tricium/functions/spellchecker/test/example.c [modify] https://crrev.com/68ec8b8d51ad6efa883518b7b4ad7c035a05c395/go/src/infra/tricium/functions/spellchecker/spellchecker.go
,
Dec 3
New version deployed, fix confirmed. https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1359252/3/example.md |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by swarnasree.mukkala@chromium.org
, Oct 5