New issue
Advanced search Search tips

Issue 892448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Offline Previews no longer triggers for non-data saver users

Project Member Reported by ryansturm@chromium.org, Oct 5

Issue description

Offline Previews is supposed to trigger for all users on slow connections, but recently code was moved behind a IsDataSaver flag that prevents offline previews from triggering.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02001900790138209c4cd6254d76e9808d01cd1b

commit 02001900790138209c4cd6254d76e9808d01cd1b
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Oct 05 20:42:23 2018

Removing URLRequest dependencies from Previews triggering code

This CL aims to move URLRequest dependencies out of Previews triggering
code (and into CRDHD methods) to allow for a much smaller CL when moving
to the UI thread. Ultimately, these methods will be called from the
content/ Navigation stack using delegates there
(ChromeContentBrowserClient). This will allow Previews decisions to
occur slightly earlier in the Navigation pathway, and it will allow
Previews to operate strictly on the UI thread.

However, PreviewsState will still be plumbed to the IO thread until DRP
is moved out of Net Delegate classes.

Instead of passing URLRequest to Previews code, the PreviewsUserData is
passed along with request information (i.e., reload, URL). These will be
available on the UI thread, so the previews methods themselves should be
able to be consumed post thread switch.

Bug:  842233 , 892448 
Change-Id: I0f7ab5d23aeb34e89bad5d027d685c348d94569a
Reviewed-on: https://chromium-review.googlesource.com/c/1259621
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597282}
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/BUILD.gn
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/DEPS
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/previews_decider.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/test_previews_decider.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/test_previews_decider.h

Status: Fixed (was: Assigned)

Sign in to add a comment