New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

setup_lab_tools fails during `build_externals`

Reported by jrbarnette@chromium.org, Oct 4

Issue description

Following the instructions for "setup_lab_tools", I see the failure
below during `build_externals`.  There's something wrong with the
"functools_lru_cache" package when we try to install it.

Aside from making developers' lives difficult, it's possible that this
breaks updates for push to prod.  So, this needs relatively urgent attention.

16:36:26 INFO | lrucache isn't present. Will install.
16:36:26 INFO | Fetching http://commondatastorage.googleapis.com/chromeos-mirror/gentoo/distfiles/backports.functools_lru_cache-1.4.tar.gz
16:36:27 INFO | Good checksum.
Traceback (most recent call last):
  File "src/third_party/autotest/files/utils/build_externals.py", line 194, in <module>
    sys.exit(main())
  File "src/third_party/autotest/files/utils/build_externals.py", line 79, in main
    package_dir, install_dir, set(options.names_to_check))
  File "src/third_party/autotest/files/utils/build_externals.py", line 145, in fetch_necessary_packages
    if not package.is_needed(install_dir):
  File "/usr/local/google/home/jrbarnette/repos/cros.tools-test/src/third_party/autotest/files/utils/external_packages.py", line 167, in is_needed
    if (not module.__file__.startswith(install_dir) and
AttributeError: 'module' object has no attribute '__file__'
A late step in this process emits a number of Python SyntaxErrors.
The installation has most likely succeeded.
Consult http://sites/chromeos/for-team-members/infrastructure/lab-tools
for sample output from a successful run.

 
Cc: jkardatzke@chromium.org
Cc: xianuowang@chromium.org
Could not reproduce by just removing functools_lru_cache and running build_externals
Can reproduce by removing site-packages, interesting
Oh, the problem is actually for logilab
Cc: gu...@chromium.org
Owner: ayatane@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f9c3e4703857db75378cfd802eb4a50917647859

commit f9c3e4703857db75378cfd802eb4a50917647859
Author: Allen Li <ayatane@chromium.org>
Date: Sat Oct 06 06:13:30 2018

autotest: Make build_externals.py recognize local packages

Packages have __path__ instead of __file__

BUG= chromium:892442 
TEST=Run build_externals

Change-Id: Ica3afa19657df5d7a36d132d1a79ac699c82a544
Reviewed-on: https://chromium-review.googlesource.com/1265977
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Congbin Guo <guocb@chromium.org>

[modify] https://crrev.com/f9c3e4703857db75378cfd802eb4a50917647859/utils/external_packages.py

Status: Fixed (was: Started)

Sign in to add a comment