71.0.3570.0

Deleted: Screenshot_20181005-073622.png 674 KB

	Screenshot_20181005-073622.png 674 KB View Download

71.0.3562.0

Deleted: Screenshot_20181005-071724.png 665 KB

	Screenshot_20181005-071724.png 665 KB View Download

@youling257@gmail.com: Thanks for reporting the issue. Can you send the device model you reproduced this issue? also android version. 

Thanks!

Android chrome tablet ui，Android os 7.1，desktop site http://4pda.ru/forum/index.php?act=idx

i won't tell you my device model.

Tested the issue in Android and able to reproduce the issue. 

Steps Followed:
1. Navigated to http://4pda.ru/forum/index.php?act=idx -- Not observing any translation bar

Chrome versions tested:
71.0.3571.0

OS:
Android 9.0.0

Android Devices:
Pixel 2 

Good Build - 71.0.3563.0
Bad Build - 71.0.3563.0 

CL: https://chromium.googlesource.com/chromium/src/+/530abd79f10af8ec610559457e5dd2d746d74aa1

@ frechette: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Adding RB-Stable for M-71, Please remove if this not the case.

Thanks!

Almost certainly attributable to https://chromium-review.googlesource.com/c/chromium/src/+/1221687. In this case, CLD language and html root language are different but complementary, but we still suppress translation (see chrome://translate-internals after navigating to page - https://screenshot.googleplex.com/vYDHb3ZTksr.png). This is not what we want to do - see thread on https://bugs.chromium.org/p/chromium/issues/detail?id=875035. The culprit CL will be reverted.

I post same bug... Pls fix.it asap... 

Android 9 mia1 same issue ... Stable/dev/canary 

not see 71.0.3572.0 fix it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89d6f0d7ea7982e72db195523356338171977c49

commit 89d6f0d7ea7982e72db195523356338171977c49
Author: Alexandre Frechette <frechette@chromium.org>
Date: Sun Oct 07 21:05:33 2018

Revert "[Language] Do not show translation offer prompt when CLD and html/content"

This reverts commit 530abd79f10af8ec610559457e5dd2d746d74aa1.

Reason for revert:
This CL needs to be reworked. It causes a memory regression (https://bugs.chromium.org/p/chromium/issues/detail?id=891257), and also has badly addressed edge cases (see thread in https://bugs.chromium.org/p/chromium/issues/detail?id=875035, causing bug https://bugs.chromium.org/p/chromium/issues/detail?id=892441).

Original change's description:
> [Language] Do not show translation offer prompt when CLD and html/content
> languages differ.
>
> There are cases where CLD is wrong, it differs from the HTML or content
> languages (signals from the webpage) and we still trust it. In such
> situation, we should not actively suggest translation, and simply show
> the icon.
>
> We achieve this by passing the signals that were used during
> language detection to the component in charge of showing translation.
>
> Bug: 875035
> Change-Id: Icbaf6ec19aeffeb246c7af03c18ee75d97fa7eeb
> Reviewed-on: https://chromium-review.googlesource.com/1221687
> Reviewed-by: Jonathan Metzman <metzman@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Michael Martis <martis@chromium.org>
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Alexandre Frechette <frechette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594323}

TBR=dcheng@chromium.org,twellington@chromium.org,anthonyvd@chromium.org,martis@chromium.org,metzman@chromium.org,frechette@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 875035,  892441 ,  891257 ,  892783 
Change-Id: I7c839fa96bee25b2a9332b3156f1de622bb47e19
Reviewed-on: https://chromium-review.googlesource.com/c/1263893
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597467}
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/chrome/browser/android/contextualsearch/contextual_search_context.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/browser/content_translate_driver.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate.mojom
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate_struct_traits.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/common/translate_struct_traits.h
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/content/renderer/translate_helper.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state.h
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/language_state_unittest.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_browser_metrics.h
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/common/language_detection_details.h
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util.h
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/core/language_detection/language_detection_util_unittest.cc
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/ios/browser/ios_translate_driver.mm
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/components/translate/ios/browser/language_detection_controller.mm
[modify] https://crrev.com/89d6f0d7ea7982e72db195523356338171977c49/testing/libfuzzer/fuzzers/language_detection_fuzzer.cc

 Issue 892957  has been merged into this issue.

Navigated to http://4pda.ru/forum/index.php?act=idx in  71.0.3573.0 and got a translation bar.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.