Issue 892436 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	vmiura@google.com
Closed:	Oct 5
Cc:	sadrul@chromium.org █ nednguyen@chromium.org tdres...@chromium.org
Components:	Internals>GPU>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug

Remove SYNC_SCROLL versions of TopRealWorldMobilePages

Project Member Reported by vmiura@google.com, Oct 4

Issue description

The SYNC_SCROLL versions of pages run with the '--disable-threaded-scrolling'.  This flag forces us to scroll on the main thread, which is an artificial mode for these pages on mobile.

The flag can be useful for measuring main thread time impact, but it doesn't seem necessary to test ~40 mobile sites with this flag.  Removing it would cut ~30 minutes from the rendering.mobile benchmark runtime.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eaee165029f703d849b54a9357e42d5b3e78133

commit 7eaee165029f703d849b54a9357e42d5b3e78133
Author: Victor Miura <vmiura@chromium.org>
Date: Fri Oct 05 15:59:32 2018

Remove SYNC_SCROLL versions of TopRealWorldMobilePages.

BUG= 892436 

Change-Id: I1576d16bb1c370710a6374482fd146e639145b91
Reviewed-on: https://chromium-review.googlesource.com/c/1263353
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597148}
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/benchmark.csv
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/expectations.config
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/page_sets/data/rendering_mobile.json
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/page_sets/rendering/rendering_stories.py
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/page_sets/rendering/story_tags.py
[modify] https://crrev.com/7eaee165029f703d849b54a9357e42d5b3e78133/tools/perf/page_sets/rendering/top_real_world_mobile.py

Comment 2 by vmiura@google.com, Oct 5

Status: Fixed (was: Started)

►

Issue 892436 link

Issue metadata

Remove SYNC_SCROLL versions of TopRealWorldMobilePages

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 5

Comment 1 Deleted

Comment 2 by vmiura@google.com, Oct 5

Comment 2 Deleted

Sign in to add a comment