[Remoting Android] Official build CRD client can't show the Credits page |
||||||
Issue descriptionApp Version: 70.0.3538.17 OS: Android 8.1.0 What steps will reproduce the problem? (1) Open side menu (2) Tap Help (3) Tap the overflow menu and tap Credits What is the expected result? The Credits page properly shows up. What happens instead? It says "Webpage not available" We found this issue is only reproducible on the official build, and not impacted on the open source build. App is good at 69.0.3489.0 and bad at 69.0.3491.0.
,
Oct 5
Looks like it's not the internal library that causes the problem. I can repro this issue with the open source build by simply changing the package identifier to com.google.chromeremotedesktop...
,
Oct 8
,
Oct 8
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/remoting/android/internal/+/7067f05056008941074c49cbc8691a0e1fe8b3b2 commit 7067f05056008941074c49cbc8691a0e1fe8b3b2 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Oct 08 20:40:17 2018
,
Oct 8
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/4b43a14ffa6843269771dbabd38bd77bcc8ae1a4 commit 4b43a14ffa6843269771dbabd38bd77bcc8ae1a4 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Oct 08 22:59:33 2018
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/459d192fce1103aa858ea158b500a84e42583f9b commit 459d192fce1103aa858ea158b500a84e42583f9b Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Oct 09 01:44:52 2018 Roll src-internal 3a56f84e52f6..a4aac8dee962 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a56f84e52f6..a4aac8dee962 Created with: gclient setdep -r src-internal@a4aac8dee962 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:892430 TBR=mmoss@chromium.org Change-Id: Ib838c8919e208fa407f6df548581604b7764bc83 Reviewed-on: https://chromium-review.googlesource.com/c/1269814 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597769} [modify] https://crrev.com/459d192fce1103aa858ea158b500a84e42583f9b/DEPS
,
Oct 9
Verified that it is fixed in 71.0.3575.0.
,
Oct 9
Request to merge this change into M70. This is just a one-line fix in the build file. The change only affects the Chrome Remote Desktop Android app and doesn't affect the Chrome browser or anything else.
,
Oct 9
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 10
Approved for merge to 70, branch 3538.
,
Oct 10
Hmm this seems to be a pain to merge.. We can't just make the M70 src-internal point to the latest remoting/android/internal because there has been some refactoring for third_party/android_tools in M71: https://chrome-internal.googlesource.com/chrome/remoting/android/internal/+/5359bbccdf157176a23fb6a8ed68a5941753ee3f I guess the only way to work around this is to create an M70 release branch on remoting/android/internal from the commit prior to the refactoring, then cherry-pick the change and make the M70 src-internal point to it... Kind of feel like we should have put our Android internal code into clank rather than having a mysteriously floating repo, much like how we do it for iOS...
,
Oct 10
Discussed offline with Jamie. I think it's just too much work to get it merged into M70 so we will wait for M71 instead.
,
Oct 15
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
Updating labels as per c#12 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yuweih@chromium.org
, Oct 4