New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892425 link

Starred by 1 user
Status: Assigned
Owner:
u...@chromium.org
Cc:
perezju@chromium.org
crouleau@google.com
█ nednguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

upload credentials.json to gs://chromium-telemetry/38f6afad3baf96684730bf307244fc7fa6bd6f7d before resubmitting crrev.com/596763

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 4 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@google.com

system_health.common_mobile/background:tools:gmail and 30 other(s) in performance_test_suite failing on chromium.perf/android-go-perf

Builders failed on: 
- android-go-perf: 
  https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-go-perf

Comment 1 by crouleau@chromium.org, Oct 4 

The last two runs failed the following two tests:

Unexpected Failures:
* system_health.common_mobile/background:tools:gmail
* system_health.common_mobile/load:tools:gmail


logs for system_health.common_mobile/background:tools:gmail

https://logs.chromium.org/v/?s=chrome%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8933563995625133792%2F%2B%2Fsystem_health.common_mobile_9bf4e25e-71d9-4771-a682-442d4db37ad6

(ERROR) 2018-10-04 21:07:35,398 story_runner.ProcessError:100  Unhandleable error. Benchmark run will be interrupted
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 300, in RunStory
    self._current_page.Run(self)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 95, in Run
    shared_state.page_test.RunNavigateSteps(self, current_tab)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py", line 152, in RunNavigateSteps
    page.RunNavigateSteps(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/system_health_story.py", line 118, in RunNavigateSteps
    self._Login(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/loading_stories.py", line 323, in _Login
    google_login.LoginGoogleAccount(action_runner, 'googletest')
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/google_login.py", line 82, in LoginGoogleAccount
    BaseLoginGoogle(action_runner, credential, credentials_path)
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/google_login.py", line 56, in BaseLoginGoogle
    credential, credentials_path=credentials_path)
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/login_utils.py", line 32, in GetAccountNameAndPassword
    DEFAULT_CREDENTIAL_PATH, DEFAULT_CREDENTIAL_BUCKET)
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 456, in GetIfChanged
    _GetLocked(bucket, expected_hash, file_path)
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 354, in _GetLocked
    _RunCommand(['cp', url, partial_download_path.name])
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 159, in _RunCommand
    raise GetErrorObjectForCloudStorageStderr(stderr)
NotFoundError: CommandException: No URLs matched: gs://chromium-telemetry/38f6afad3baf96684730bf307244fc7fa6bd6f7d



logs for load:tools:gmail 

https://logs.chromium.org/v/?s=chrome%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8933563995625133792%2F%2B%2Fsystem_health.common_mobile_427cc2e1-b2c5-46e2-980f-a9e06e9f3de6

(ERROR) 2018-10-04 21:07:53,591 story_runner.ProcessError:100  Unhandleable error. Benchmark run will be interrupted
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 300, in RunStory
    self._current_page.Run(self)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 95, in Run
    shared_state.page_test.RunNavigateSteps(self, current_tab)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py", line 152, in RunNavigateSteps
    page.RunNavigateSteps(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/system_health_story.py", line 118, in RunNavigateSteps
    self._Login(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/loading_stories.py", line 323, in _Login
    google_login.LoginGoogleAccount(action_runner, 'googletest')
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/google_login.py", line 82, in LoginGoogleAccount
    BaseLoginGoogle(action_runner, credential, credentials_path)
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/google_login.py", line 56, in BaseLoginGoogle
    credential, credentials_path=credentials_path)
  File "/b/swarming/w/ir/tools/perf/page_sets/login_helpers/login_utils.py", line 32, in GetAccountNameAndPassword
    DEFAULT_CREDENTIAL_PATH, DEFAULT_CREDENTIAL_BUCKET)
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 456, in GetIfChanged
    _GetLocked(bucket, expected_hash, file_path)
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 354, in _GetLocked
    _RunCommand(['cp', url, partial_download_path.name])
  File "/b/swarming/w/ir/third_party/catapult/common/py_utils/py_utils/cloud_storage.py", line 159, in _RunCommand
    raise GetErrorObjectForCloudStorageStderr(stderr)
NotFoundError: CommandException: No URLs matched: gs://chromium-telemetry/38f6afad3baf96684730bf307244fc7fa6bd6f7d

Comment 3 by crouleau@chromium.org, Oct 4

Owner: u...@chromium.org
Status: Assigned (was: Available)

Comment 4 by crouleau@chromium.org, Oct 4 

crrev.com/596763 I think is the culprit.

Comment 5 by crouleau@chromium.org, Oct 4 

Maybe the fix is as simple as

gsutil.py cp credentials.json gs://chromium-telemetry/38f6afad3baf96684730bf307244fc7fa6bd6f7d

but I don't know where I can find credentials.json.

Comment 6 by crouleau@chromium.org, Oct 4

Cc: perezju@chromium.org

Comment 7 by crouleau@chromium.org, Oct 4 

I think I'll just revert the change. Doesn't seem risky.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c64ae57963ae60fd53831f5d2371afc93607dc08

commit c64ae57963ae60fd53831f5d2371afc93607dc08
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Thu Oct 04 23:30:20 2018

Revert "[perf] Add browse:media:tumblr:2018 system health story"

This reverts commit 60ed0f8da58737853e785166fcb7db1a57ce1eca.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [perf] Add browse:media:tumblr:2018 system health story
> 
> This also add a login helper for tumblr and updates credentials.json
> 
> Bug: 878390
> Change-Id: Iba56faf550cb638692899326b217347e04be9932
> Reviewed-on: https://chromium-review.googlesource.com/c/1256883
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596763}

TBR=ulan@chromium.org,perezju@chromium.org,cbruni@chromium.org

Change-Id: Ie3500851b331cb8be91fd0f1f8a5de148e63ab70
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878390,892425
Reviewed-on: https://chromium-review.googlesource.com/c/1263351
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596920}
[modify] https://crrev.com/c64ae57963ae60fd53831f5d2371afc93607dc08/tools/perf/page_sets/data/credentials.json.sha1
[modify] https://crrev.com/c64ae57963ae60fd53831f5d2371afc93607dc08/tools/perf/page_sets/data/system_health_desktop.json
[delete] https://crrev.com/b72f6d2f2a9ebde30866cba6b76f4b9b3ad25f71/tools/perf/page_sets/data/system_health_desktop_55cb9dd713.wprgo.sha1
[delete] https://crrev.com/b72f6d2f2a9ebde30866cba6b76f4b9b3ad25f71/tools/perf/page_sets/login_helpers/tumblr_login.py
[modify] https://crrev.com/c64ae57963ae60fd53831f5d2371afc93607dc08/tools/perf/page_sets/system_health/browsing_stories.py

Comment 9 by crouleau@chromium.org, Oct 4

Summary: upload credentials.json to gs://chromium-telemetry/38f6afad3baf96684730bf307244fc7fa6bd6f7d before resubmitting crrev.com/596763 (was: system_health.common_mobile/background:tools:gmail and 30 other(s) in performance_test_suite failing on chromium.perf/android-go-perf)

Comment 10 by perezju@chromium.org, Oct 5

Cc: nednguyen@chromium.org
+Ned, maybe we're also missing a test somewhere to catch this earlier.

Comment 11 by u...@chromium.org, Oct 5 

Ned, Juan, I ran
upload_to_google_storage.py --bucket chrome-partner-telemetry  tools/perf/page_sets/data/credentials.json
before uploading the CL.

Is this not sufficient?
►

Sign in to add a comment