New issue
Advanced search Search tips

Issue 892385 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

legacy frame_times metrics fallback to non-SF timestamps

Project Member Reported by chiniforooshan@chromium.org, Oct 4

Issue description

In https://chromium-review.googlesource.com/c/catapult/+/1258877 I deleted SurfaceFlinger data from legacy smoothness metrics, thinking it's not needed anymore. I was wrong; they are used in legacy frame_times and percentage_smooth metrics, that still exist. This caused regressions in those metrics.

One fix is to replace the metrics with TBMv2 versions, that have SurfaceFlinger data.
 
https://chromeperf.appspot.com/report?sid=eee50d4a00e0069b77f2b1e1d79fd61a0d2ab5625df8b15d131e030f00601955&start_rev=585373&end_rev=597101

is an example showing that replacing frame_times with frame_times_tbmv2 is likely to resolve the regression.

The fix is under review: https://chromium-review.googlesource.com/c/catapult/+/1264176
Cc: m...@chromium.org chiniforooshan@chromium.org
 Issue 893786  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/0480f8caeb27101608c99e4df2f686d6697551f4

commit 0480f8caeb27101608c99e4df2f686d6697551f4
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Thu Oct 11 17:16:47 2018

Telemetry: migrate frame_times & percentage_smooth

This migrates frame_times_tbmv2 to frame_times and
smooth_frames to percentage_smooth. The rename for
smooth_frames is for continuity of graphs in perf dashboard.
We can rename the metric if we want later and migrate data.

This migration also fixes  crbug.com/892385 

To compare old/new values:
https://v2spa-dot-chromeperf.appspot.com/#session=2ba522d010d5e4a81b1bfa24be6d8d5a2e29ff6d49af15721377314c49a4ea1d

Bug:  chromium:890757 
Bug:  chromium:892385 
Change-Id: If5411c66b753ccaaa62543e886c423f338667619
Reviewed-on: https://chromium-review.googlesource.com/c/1264176
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>

[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/frame_time.html
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/rendering_stats.py
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/frame_time_test.html
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/tracing/tracing/metrics/rendering/rendering_metric_test.html
[modify] https://crrev.com/0480f8caeb27101608c99e4df2f686d6697551f4/telemetry/telemetry/web_perf/metrics/smoothness.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27

commit bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 12 22:54:58 2018

Roll src/third_party/catapult c8b97e37ec9c..99b88b0a2d58 (21 commits)

https://chromium.googlesource.com/catapult.git/+log/c8b97e37ec9c..99b88b0a2d58


git log c8b97e37ec9c..99b88b0a2d58 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 simonhatch@chromium.org Pinpoint - Merge bugs with same root cause.
2018-10-12 benjhayden@chromium.org Change deprecation warnings in /api/alerts to errors.
2018-10-12 benjhayden@chromium.org Cache report names, test suites, and descriptors in v2spa service worker
2018-10-12 chiniforooshan@chromium.org Telemetry: process all rendering pipeline events
2018-10-12 benjhayden@chromium.org Cache session ids in v2spa service worker.
2018-10-12 benjhayden@chromium.org Fix links in rollback.md
2018-10-12 benjhayden@chromium.org Add KeyValueCacheRequest for v2spa service worker.
2018-10-12 benjhayden@chromium.org Add ts_mon metrics to common/timing.py
2018-10-12 benjhayden@chromium.org Add CacheRequestBase for v2spa service worker.
2018-10-12 nednguyen@google.com [Telemetry] Add --test-filter flag that support exact matching of multiple tests
2018-10-12 sadrul@chromium.org rendering: Generate metrics at the 95%ile.
2018-10-12 pasko@chromium.org androidStartupMetric: re-introduce First Contentful Paint
2018-10-12 chrishtr@chromium.org Clean up categories to match current tracing in Blink.
2018-10-11 jbudorick@chromium.org Revert "Enable orderfile memory optimization in benchmarks"
2018-10-11 benjhayden@chromium.org Add task queue for v2spa service worker.
2018-10-11 benjhayden@chromium.org Remove unnecessary file dashboard/test/index.html
2018-10-11 perezju@chromium.org [soundwave] Allow points with missing r_chromium
2018-10-11 chiniforooshan@chromium.org Telemetry: migrate frame_times & percentage_smooth
2018-10-11 ulan@chromium.org [tracing] Restore the minimum mutator utilization metric.
2018-10-11 seanmccullough@chromium.org [chromeperf] add prefix to wct script so tests get found.
2018-10-11 pasko@chromium.org Enable orderfile memory optimization in benchmarks


Created with:
  gclient setdep -r src/third_party/catapult@99b88b0a2d58

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:840872, chromium:893199 ,chromium:867060,chromium:894261,chromium:894287, chromium:886621 ,chromium:893514,chromium:758566, chromium:879526 , chromium:890757 , chromium:892385 , chromium:877660 ,chromium:758566
TBR=sullivan@chromium.org

Change-Id: I469ed20d66790fa12e290ad65e2ea51c16cfdba7
Reviewed-on: https://chromium-review.googlesource.com/c/1279078
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599392}
[modify] https://crrev.com/bb11cbc66e56a475bdf0f5bf3d962cf80c3afe27/DEPS

Status: Fixed (was: Started)
frame_times issue is fixed:

https://chromeperf.appspot.com/report?sid=93613cbd800855bd1113db7b38402e02714e8b810684d21b601b12d66caec290&start_rev=593484&end_rev=599662

There is a 2nd bug with percentage_smooth that is being tracked in  crbug.com/895096 .

Will mark this as fixed since the SurfaceFlinger timestamp issue is now fixed.
Status: Started (was: Fixed)
Hmm, I found another frame_times graph that is not recovered yet:

https://chromeperf.appspot.com/report?sid=ee2020d4c25746ce108a1a3939c4da03096a384d5504658d307543e9b81bd649&start_rev=594549&end_rev=599683
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12a56d6ce40000
Status: Fixed (was: Started)

Sign in to add a comment