New issue
Advanced search Search tips

Issue 892380 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 892644
Owner: ----
Closed: Oct 5
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

android-binary-size trybot failing

Project Member Reported by mheikal@google.com, Oct 4

Issue description

Binary size trybot failing with error:
Unknown entry: assets/webapk_dex_version.txt 1
  Traceback (most recent call last):
    File "/b/swarming/w/ir/cache/builder/src/build/android/resource_sizes.py", line 752, in <module>
      sys.exit(main())
    File "/b/swarming/w/ir/cache/builder/src/build/android/resource_sizes.py", line 732, in main
      _PrintDexAnalysis(args.apk, chartjson=chartjson)
    File "/b/swarming/w/ir/cache/builder/src/build/android/resource_sizes.py", line 621, in _PrintDexAnalysis
      for data in GenerateDexAnalysis(apk_filename):
    File "/b/swarming/w/ir/cache/builder/src/build/android/resource_sizes.py", line 606, in GenerateDexAnalysis
      sizes, total_size = method_count.ExtractSizesFromZip(apk_filename)
    File "/b/swarming/w/ir/cache/builder/src/build/android/method_count.py", line 79, in ExtractSizesFromZip
      cur_counts, cur_total = _ExtractSizesFromDexFile(extracted_path)
    File "/b/swarming/w/ir/cache/builder/src/build/android/method_count.py", line 58, in _ExtractSizesFromDexFile
      for line in dexdump.DexDump(dex_path, file_summary=True):
    File "/b/swarming/w/ir/cache/builder/src/third_party/catapult/devil/devil/utils/cmd_helper.py", line 495, in _IterCmdOutputLines
      raise subprocess.CalledProcessError(process.returncode, cmd)
  subprocess.CalledProcessError: Command '/b/swarming/w/ir/cache/builder/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/dexdump /b/swarming/w/ir/tmp/t/tmpYV26mR_dex_extract/classes2.dex -f' returned non-zero exit status 1
  step returned non-zero exit code: 1
4.87s since last line 2018-10-04 5:43:21 PM (EDT) 2018-10-04 2:43:21 PM (MTV) 2018-10-04 9:43:21 PM (UTC)


This is probably a bug in the reporting code since trying the command locally (dexdump) produced this:

$ third_party/catapult/devil/bin/deps/linux2/x86_64/bin/dexdump /tmp/tmpyRsgEQ_dex_extract/classes2.dex
Processing '/tmp/tmpyRsgEQ_dex_extract/classes2.dex'...
E/libdex  (28201): ERROR: unsupported dex version (30 33 37 00)
E/libdex  (28201): ERROR: Byte swap + verify failed
ERROR: Failed structural verification of '/tmp/tmpyRsgEQ_dex_extract/classes2.dex'

The command succeeds when using the android_tools dexdump utility in third_party/android_tools/sdk/build-tools/27.0.3/dexdump


This probably requires an update to the dexdump version that catapult is using


 
Ok so the unknown entry line "Unknown entry: assets/webapk_dex_version.txt 1" is unrelated to the crash/failure, it is just a warning that happens before (and unrelated to) the crash.

This is basically just dexdump failing.

Also here is a link to the trybot failure https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/69123
The dexdump utility that catapult uses is provided by us rather than by catapult. Since it is not checked in, it is probably pulled in via gclient hooks however I am unsure who I should contact about updating it (or how to update it myself).
Mergedinto: 892644
Status: Duplicate (was: Untriaged)
Filed a bug to infra>client>chrome

Sign in to add a comment