The refactoring will mainly consist of: 1) Moving all infobar implementation from BVC behind an InfobarCoordinator 2) Move the infobarContainer into a ViewController, that way BVC will present a VC for infobars instead of just adding a view.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ed291b656ba5632c25ee21c722a09df0d66b1fb commit 8ed291b656ba5632c25ee21c722a09df0d66b1fb Author: sczs <sczs@chromium.org> Date: Thu Oct 11 21:07:38 2018 [ios] Boxes InfobarContainer inside InfoBarCoordinator. - Creates InfobarCoordinator, which for now will be used as the public interface of infobarContainer, and will serve the function of InfoBarContainerDelegateIOS. - Creates an Infobar positioner protocol that will help the delegate position the infobarContainer, this will use LayoutGuides in followup CL's - Moves current infobars files from the infobars source_set to a new infobars_ui source_set. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I825c1ff2ce18930b4dc7a642f067d0d77b64302a Reviewed-on: https://chromium-review.googlesource.com/c/1263278 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#598937} [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/infobars/BUILD.gn [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/autofill/BUILD.gn [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/infobars/BUILD.gn [add] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/infobars/infobar_coordinator.h [add] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/infobars/infobar_coordinator.mm [add] https://crrev.com/8ed291b656ba5632c25ee21c722a09df0d66b1fb/ios/chrome/browser/ui/infobars/infobar_positioner.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a commit 4bbc7bc229d0a80db1c5cf94d10977bca7014e8a Author: sczs <sczs@chromium.org> Date: Mon Oct 15 16:07:59 2018 [iOS] Makes InfoBarCoordinator a TabModel observer. - Moves all the TabModel observer infoBar related code from BVC to the infoBarCoordinator. - Makes infoBarCoordinator conform to the SigninPresenter protocol. - Plumbs a dispatcher a tabModel to the infoBarCoordinator. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I002fa94a09566770117f1a30c7c6d656e0fba559 Reviewed-on: https://chromium-review.googlesource.com/c/1265501 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#599648} [modify] https://crrev.com/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/4bbc7bc229d0a80db1c5cf94d10977bca7014e8a/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfde573830f21549906885659a60ab3190360c17 commit bfde573830f21549906885659a60ab3190360c17 Author: sczs <sczs@chromium.org> Date: Tue Oct 16 15:53:26 2018 [ios] Moves Infobar UI setup to InfobarCoordinator - The infobarContainerView is now being added in the Coordinator start method. - The infobarCoordinator now starts right after its initialized. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifd5e99e165280df73849f5590e2ccbe9d32945c8 Reviewed-on: https://chromium-review.googlesource.com/c/1282035 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#600001} [modify] https://crrev.com/bfde573830f21549906885659a60ab3190360c17/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/bfde573830f21549906885659a60ab3190360c17/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5000251c01d99da4289f6dbd2175e4025718214c commit 5000251c01d99da4289f6dbd2175e4025718214c Author: sczs <sczs@chromium.org> Date: Tue Oct 16 17:34:13 2018 [ios] Removes InfoBarManager from BVC. - Makes InfobarCoordinator conform to the UpgradeCenterClient protocol. - Adds a isInfobarPresentingForTab method to InfobarCoordinator. Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I11e8d15a05c196765caff39885aa14053870817f Reviewed-on: https://chromium-review.googlesource.com/c/1281862 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600029} [modify] https://crrev.com/5000251c01d99da4289f6dbd2175e4025718214c/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5000251c01d99da4289f6dbd2175e4025718214c/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5000251c01d99da4289f6dbd2175e4025718214c/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/5000251c01d99da4289f6dbd2175e4025718214c/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/5000251c01d99da4289f6dbd2175e4025718214c/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64 commit 49f7b5a7a8a2a24edd9b20eff84c217beefc8c64 Author: sczs <sczs@chromium.org> Date: Thu Oct 18 22:14:08 2018 [ios] Decouples InfobarContainerView from InfobarContainerIOS - InfobarCoordinator now owns the InfobarContainerView. - Creates a consumer protocol to communicate between InfobarContainerIOS and InfobarContainerView. Paving the way for a mediator. - Deletes cr_transitionWithView in favor of the stock method since InfobarContainerView was the last class using it Bug: 892376 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ed216e48096bf59ec485460dc42dab250177e01 Reviewed-on: https://chromium-review.googlesource.com/c/1287315 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600935} [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/infobars/BUILD.gn [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/infobars/infobar_container_ios.h [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/infobars/infobar_container_ios.mm [delete] https://crrev.com/6673c997eaf66f03baadecf1381ee2b533e06026/ios/chrome/browser/infobars/infobar_container_view.h [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/ui/infobars/BUILD.gn [add] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/ui/infobars/infobar_container_consumer.h [add] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/ui/infobars/infobar_container_view.h [rename] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/ui/infobars/infobar_container_view.mm [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/browser/ui/infobars/infobar_coordinator.mm [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/common/material_timing.h [modify] https://crrev.com/49f7b5a7a8a2a24edd9b20eff84c217beefc8c64/ios/chrome/common/material_timing.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/744e9c97d750e360fb94e3855fa140773f5cb0b1 commit 744e9c97d750e360fb94e3855fa140773f5cb0b1 Author: sczs <sczs@chromium.org> Date: Wed Oct 24 16:52:38 2018 [ios] Creates InfobarContainerViewController - Moves InfobarContainerView inside a newly created InfobarContainerVC. - Adds constraints between InfobarContainerVC and the contained infobar, this makes it possible to delete some re-layouting calls that needed to happen whenever the Infobar changed heights. - Makes InfobarContainerVC conform to the SignInPresenter and InfobarContainerStateDelegate protocol instead of the Coordinator. Bug: 892376 Change-Id: I92d4dc6f82e9062311dee2936c28e3d8ec62b485 Reviewed-on: https://chromium-review.googlesource.com/c/1294469 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602371} [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/infobars/infobar_container_ios.mm [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/infobar_container_consumer.h [delete] https://crrev.com/20a76ff5b7298d2e97f9dcb9faee7915677dda57/ios/chrome/browser/ui/infobars/infobar_container_view.h [delete] https://crrev.com/20a76ff5b7298d2e97f9dcb9faee7915677dda57/ios/chrome/browser/ui/infobars/infobar_container_view.mm [add] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/infobar_container_view_controller.h [add] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/744e9c97d750e360fb94e3855fa140773f5cb0b1/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/623a610238aef2021e5230c2069d3793c117fcc8 commit 623a610238aef2021e5230c2069d3793c117fcc8 Author: sczs <sczs@chromium.org> Date: Wed Oct 31 15:46:07 2018 [ios] Creates Infobar EG test cases for stacked infobars - Adds message parameter support for TestInfobarDelegate. - Adds Infobar eg test cases for stacked Infobars. Bug: 892376 Change-Id: I9f1f8b16d84ab0bf19111fa50e790319414a9a2d Reviewed-on: https://chromium-review.googlesource.com/c/1308900 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604267} [modify] https://crrev.com/623a610238aef2021e5230c2069d3793c117fcc8/ios/chrome/browser/ui/infobars/infobar_egtest.mm [modify] https://crrev.com/623a610238aef2021e5230c2069d3793c117fcc8/ios/chrome/browser/ui/infobars/test_infobar_delegate.h [modify] https://crrev.com/623a610238aef2021e5230c2069d3793c117fcc8/ios/chrome/browser/ui/infobars/test_infobar_delegate.mm [modify] https://crrev.com/623a610238aef2021e5230c2069d3793c117fcc8/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab3a8c0100adbade01e8e31b94e39350da7a33dd commit ab3a8c0100adbade01e8e31b94e39350da7a33dd Author: sczs <sczs@chromium.org> Date: Wed Oct 31 18:58:46 2018 [ios] Creates InfobarContainerMediator - Moves model code from InfobarCoordinator to InfobarContainerMediator. - Makes InfobarContainerMediator InfobarContainerStateDelegate instead of InfobarContainerVC, this way all communication to the VC is made via the consumer protocol. Bug: 892376 Change-Id: I8d4887f614d0bc1ceb0510d4c6d232c0c13281c0 Reviewed-on: https://chromium-review.googlesource.com/c/1297580 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604355} [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_container_consumer.h [add] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_container_mediator.h [add] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_container_mediator.mm [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_container_view_controller.h [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/ab3a8c0100adbade01e8e31b94e39350da7a33dd/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fbae555786d079903f5b131966682ab8d260526 commit 6fbae555786d079903f5b131966682ab8d260526 Author: sczs <sczs@chromium.org> Date: Thu Nov 08 17:06:30 2018 [ios] Removes Layout() InfobarIOS method. Since the ContainerView size is now dependent on the InfobarView (The ContainerView autolayout constraints are anchored against the InfobarView, and we set the containerView to match the InfobarView height), there's no need to pass the ContainerView frame to layout the InfobarView. Because of this InfobarContainerVC no longer needs to import InfobarIOS and its moved to the infobars_ui BUILD.gn source_set. Bug: 892376 Change-Id: I44ca8c470b0ededbd34fe2f1564c2d651f200317 Reviewed-on: https://chromium-review.googlesource.com/c/1315987 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606504} [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/confirm_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar.h [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar_container_ios.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar_controller+protected.h [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar_controller.h [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/infobars/infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/translate/after_translate_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/translate/before_translate_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/translate/never_translate_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/translate/translate_message_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate_unittest.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/infobars/infobar_container_consumer.h [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/infobars/infobar_container_view_controller.h [modify] https://crrev.com/6fbae555786d079903f5b131966682ab8d260526/ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed44ca7afd8bf781788f73b8df6db9f3bde38a18 commit ed44ca7afd8bf781788f73b8df6db9f3bde38a18 Author: sczs <sczs@chromium.org> Date: Thu Nov 08 20:29:59 2018 [ios] Deletes Infobar Sizing Delegates Before this CL Infobar.cc was informing InfobarContainer of an InfobarView resize. Also, the InfobarView was being set by Infobar.cc it now sets its own height. This CL: - Adds functionality so InfobarContainer resizing is driven by UiKit. - Deletes InfobarViewSizing and InfobarViewSizingDelegate. - Removes the plumbing from InfobarView that informs Infobar.cc of a resize. - Removes InfobarIOS and InfobarController methods that were used to resize the InfobarView. Bug: 892376 Change-Id: Iaae3c0ec36ce226fc89fb405cb3d9c40376d3a79 Reviewed-on: https://chromium-review.googlesource.com/c/1321849 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#606589} [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/confirm_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar_controller+protected.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar_controller.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/infobars/infobar_controller_delegate.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/translate/after_translate_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/translate/before_translate_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/translate/never_translate_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/translate/translate_message_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/autofill/save_card_infobar_view.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/infobars/confirm_infobar_view.h [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm [modify] https://crrev.com/ed44ca7afd8bf781788f73b8df6db9f3bde38a18/ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm [delete] https://crrev.com/d27bb5431562964962e8eef4a4374d27290b218d/ios/chrome/browser/ui/infobars/infobar_view_sizing.h [delete] https://crrev.com/d27bb5431562964962e8eef4a4374d27290b218d/ios/chrome/browser/ui/infobars/infobar_view_sizing_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bbfdb18359ae277f37129d3beed2d8b2e814893 commit 9bbfdb18359ae277f37129d3beed2d8b2e814893 Author: sczs <sczs@chromium.org> Date: Fri Nov 09 18:42:16 2018 [ios] Deletes InfobarContainerDelegates Since the InfobarView is no longer communicating its size to Infobar.cc there's no need to have the machinery necessary so Infobar.cc communicates with our InfobarContainerView. The InfobarContainerView will be updated via the VC viewDidLayoutSubviews which was the change made on https://crrev.com/c/1321849/ Adds an extra test case. Bug: 892376 Change-Id: I5457c17a8e1e586b02b5ca9906abd4341e5a56d4 Reviewed-on: https://chromium-review.googlesource.com/c/1325034 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606911} [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/infobars/BUILD.gn [delete] https://crrev.com/a5a398e8c144eaeaf45b0e5701cf15cf39fd8e4e/ios/chrome/browser/infobars/infobar_container_delegate_ios.h [delete] https://crrev.com/a5a398e8c144eaeaf45b0e5701cf15cf39fd8e4e/ios/chrome/browser/infobars/infobar_container_delegate_ios.mm [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/infobars/infobar_container_ios.h [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/infobars/infobar_container_ios.mm [delete] https://crrev.com/a5a398e8c144eaeaf45b0e5701cf15cf39fd8e4e/ios/chrome/browser/infobars/infobar_container_state_delegate.h [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/ui/infobars/infobar_container_mediator.mm [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/9bbfdb18359ae277f37129d3beed2d8b2e814893/ios/chrome/browser/ui/infobars/infobar_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bb08aa27446a3361e60a01c1e6f3e53704446d4 commit 8bb08aa27446a3361e60a01c1e6f3e53704446d4 Author: sczs <sczs@chromium.org> Date: Wed Nov 14 20:29:54 2018 [ios] Removes isParentViewVisible from InfobarPositioner Since now InfobarContainer is a VC we no longer need to get this info from the parent VC. Bug: 892376 Change-Id: I04a7af0676437e20ebe0c31db16f0bf88c7b4ec6 Reviewed-on: https://chromium-review.googlesource.com/c/1331171 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608110} [modify] https://crrev.com/8bb08aa27446a3361e60a01c1e6f3e53704446d4/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/8bb08aa27446a3361e60a01c1e6f3e53704446d4/ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm [modify] https://crrev.com/8bb08aa27446a3361e60a01c1e6f3e53704446d4/ios/chrome/browser/ui/infobars/infobar_positioner.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df8b70f751a1f4d6e2be23acce2b979fa9fe6f4a commit df8b70f751a1f4d6e2be23acce2b979fa9fe6f4a Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Nov 21 16:44:11 2018 [IOS] Replaces InfobarController's view accessor with readonly property Bug: 892376 Change-Id: I6f3a802cb11eb18f6470b35d70f683a7b0c9abaa Reviewed-on: https://chromium-review.googlesource.com/c/1335879 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610102} [modify] https://crrev.com/df8b70f751a1f4d6e2be23acce2b979fa9fe6f4a/ios/chrome/browser/infobars/confirm_infobar_controller+protected.h [modify] https://crrev.com/df8b70f751a1f4d6e2be23acce2b979fa9fe6f4a/ios/chrome/browser/infobars/infobar_controller.h [modify] https://crrev.com/df8b70f751a1f4d6e2be23acce2b979fa9fe6f4a/ios/chrome/browser/infobars/infobar_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4ff69492af470913f50eebc6784302e81e170a1 commit a4ff69492af470913f50eebc6784302e81e170a1 Author: sczs <sczs@chromium.org> Date: Fri Nov 30 00:36:58 2018 [ios] Makes sczs@ Infobar OWNER After the recent Infobar refactoring I think I have enough knowledge to become an Infobar owner. This will also help on the implementation of the new design. Doc: go/bling-infobar-refactoring CLs: https://crbug.com/892376 Bug: 892376 Change-Id: Idaf4bc27e8ab2f490ad5d93268331616a35a0b71 Reviewed-on: https://chromium-review.googlesource.com/c/1354560 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#612475} [modify] https://crrev.com/a4ff69492af470913f50eebc6784302e81e170a1/ios/chrome/browser/infobars/OWNERS [modify] https://crrev.com/a4ff69492af470913f50eebc6784302e81e170a1/ios/chrome/browser/ui/infobars/OWNERS
Comment 1 by bugdroid1@chromium.org
, Oct 11