swarming task UI displays secret bytes |
||||
Issue descriptionhttps://chrome-swarming.appspot.com/task?id=4059d5c500e0af10&refresh=10&show_raw=1&wide_logs=true displays "Secret bytes" field. this is not even supposed to be surfable at the API level, moreover at UI level.
,
Oct 4
ok, looks like this is not actually secret bytes, but base64-encoded string "<REDACTED>" kjlubick@chromium.org, please remove the field.
,
Oct 4
hunter2
,
Oct 4
The field is important to know if a secret was provided. It's the server that returns this, it's not a bug in the UI.
,
Oct 4
if that's the intention, i think it should be communicated more clearly, e.g. "this task has secret bytes", not "the secret bytes of this task is this-blob-that-looks-like-actual-secret-bytes"
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/5f31637171491a79d13e45b28b484dbe105b397d commit 5f31637171491a79d13e45b28b484dbe105b397d Author: Kevin Lubick <kjlubick@google.com> Date: Wed Oct 31 17:56:33 2018 Make secret bytes less opaque Bug: 892371 Change-Id: Ic0e18bbd575bfbb770e22deb2381fd600dc23853 Reviewed-on: https://chromium-review.googlesource.com/c/1308458 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/5f31637171491a79d13e45b28b484dbe105b397d/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/5f31637171491a79d13e45b28b484dbe105b397d/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Dec 14
This has been live for a while. |
||||
►
Sign in to add a comment |
||||
Comment 1 by no...@chromium.org
, Oct 4Owner: no...@chromium.org
Status: Started (was: Untriaged)