New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892358 link

Starred by 1 user
Status: Assigned
Owner:
█ rkaplow@chromium.org
Last visit > 30 days ago
Cc:
billorr@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Migrate NavigatorVR to shared UKM SourceId

Project Member Reported by holte@google.com, Oct 4 
There is a usage of UpdateSourceURL in
third_party/blink/renderer/modules/vr/navigator_vr.cc

It looks like it should probably change to just use Document->GetSourceId, but it's unclear why it was changed away:

https://chromium-review.googlesource.com/c/chromium/src/+/1008171

Comment 1 by ddorwin@chromium.org, Oct 4

Cc: billorr@chromium.org
Components: -UI>Browser>VR Blink>WebXR>VR
Status: Assigned (was: Available)

Comment 2 by billorr@chromium.org, Oct 4 

https://chromium-review.googlesource.com/c/chromium/src/+/1008171/1/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc#136

I think we were concerned about iframes - we wanted top-frame url for iframes using API, since several partners using the API were always going to be nested in iframes.

Comment 3 by holte@google.com, Oct 4 

Ok, that case can now be covered by using Document::UkmSourceId, and analyzing  the associated DocumentCreated events, which link it to the main-frame navigation.

https://g3doc.corp.google.com/analysis/uma/g3doc/ukm/readable-analysis.md#processing-events-attached-to-blink-document-sources

So we should be able to migrate this back now.
►

Sign in to add a comment