New issue
Advanced search Search tips

Issue 892357 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 827532



Sign in to add a comment

KioskUpdateTest.LaunchCachedOfflineEnabledAppNoNetwork fails with network service enabled

Project Member Reported by rmcelrath@chromium.org, Oct 4

Issue description

KioskUpdateTest.LaunchCachedOfflineEnabledAppNoNetwork goes to the 'Local Auth Server' screen instead of the Kiosk screen on chromeos when the network service is enabled.
 
Owner: cmumford@chromium.org
Status: Assigned (was: Available)
Owner: ----
Status: Available (was: Assigned)
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b9b70828cacafc432f4762a40153dda9bde4384

commit 5b9b70828cacafc432f4762a40153dda9bde4384
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Mon Jan 14 21:08:38 2019

Fix KioskUpdateTest.LaunchCachedOfflineEnabledAppNoNetwork with NetworkService

LaunchCachedOfflineEnabledAppNoNetwork precaches an app, and then tries
to start it with the network disabled. The app is made up of a crx file,
and webstore metadata, but the test was only waiting for the crx data
to be precached. Previously, the metadata wasn't actually precached,
and instead it was requested during the test itself, which was supposed
to be offline. This CL makes the test wait for the metadata as well as
the crx file before starting the test, so the test itself doesn't
actually have to make any network requests.

Bug:  892357 
Change-Id: I0fbbaebc8185640eab67a7d3f6ce51ac500a5422
Reviewed-on: https://chromium-review.googlesource.com/c/1407737
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622599}
[modify] https://crrev.com/5b9b70828cacafc432f4762a40153dda9bde4384/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/5b9b70828cacafc432f4762a40153dda9bde4384/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment