New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892314 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Oct 10
Cc:
steve...@chromium.org
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

VirtualKeyboardControllerAutoTest is flaky

Project Member Reported by jamescook@chromium.org, Oct 4 
Build with these gn args:
dcheck_always_on = true
is_debug = false
is_component_build = true
remove_webcore_debug_symbols=true
target_os = "chromeos"
use_goma = true

Run:
testing/xvfb.py out/Default/ash_unittests

These tests always fail on the first run:

[2759/2765] VirtualKeyboardControllerAutoTest.SuppressedInTabletMode (70 ms)
[2760/2765] VirtualKeyboardControllerAutoTest.SuppressedIfExternalKeyboardPresent (108 ms)
[2761/2765] VirtualKeyboardControllerAutoTest.HandleMultipleKeyboardsPresent (67 ms)
[2762/2765] VirtualKeyboardControllerAutoTest.EnabledDuringTabletMode (71 ms)
[2763/2765] VirtualKeyboardControllerAutoTest.DisabledIfNoTouchScreen (66 ms)
[2764/2765] VirtualKeyboardControllerAutoTest.DisabledIfInternalKeyboardPresent (74 ms)

Example:
VirtualKeyboardControllerAutoTest.DisabledIfInternalKeyboardPresent
../../ash/keyboard/virtual_keyboard_controller_unittest.cc:275: Failure
Value of: keyboard::IsKeyboardEnabled()
  Actual: true
Expected: false

Comment 1 by jamescook@chromium.org, Oct 4 

Fix: https://chromium-review.googlesource.com/c/chromium/src/+/1262622

Might not be necessary after some of Steven's work.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0e5a2b77cfe3750410fd1a25aa43cdd132cba7

commit bc0e5a2b77cfe3750410fd1a25aa43cdd132cba7
Author: James Cook <jamescook@chromium.org>
Date: Tue Oct 09 16:48:30 2018

chromeos: Fix flaky VirtualKeyboardControllerAutoTest

Tests were leaking global state for keyboard and possible input deives.

Bug:  892314 
Test: ash_unittests
Change-Id: I57b2f185190574e02659e7bf51100b8f72aa6128
Reviewed-on: https://chromium-review.googlesource.com/c/1262622
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597955}
[modify] https://crrev.com/bc0e5a2b77cfe3750410fd1a25aa43cdd132cba7/ash/keyboard/virtual_keyboard_controller_unittest.cc

Comment 3 by jamescook@chromium.org, Oct 10

Status: Fixed (was: Started)
►

Sign in to add a comment