New issue
Advanced search Search tips

Issue 892285 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 894703
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: BrowserSideFlingBrowserTest.TouchpadFlingBubblesFromOOPIF



Sign in to add a comment

BrowserSideFlingBrowserTest.TouchpadFlingBubblesFromOOPIF is flaky

Project Member Reported by Findit, Oct 4

Issue description

Owner: sahel@chromium.org
Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0528108bb9a5b54b67af1d46ba708efff9f4f534

commit 0528108bb9a5b54b67af1d46ba708efff9f4f534
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Oct 04 19:11:11 2018

Revert "Fix the regression for fling bubbling from oopif."

This reverts commit d5861294468c74b20335fe93ec01086ea21acec6.

Reason for revert: New browser tests are flaky.

Original change's description:
> Fix the regression for fling bubbling from oopif.
> 
> Calling PrgoressFling right after Processing GFS which landed in
> https://chromium-review.googlesource.com/1140912 was the root cause of this
> regression.
> 
> This cl changes the fling controller logic to wait for the scheduler to
> call progress fling. The following browser tests are also added to make sure
> that the regression won't happen in the future.
> 
> Bug:  884728 ,  249063 
> Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
> Change-Id: I3018b32c9d40d36406b4f532dcab6cccf3ee3b97
> Reviewed-on: https://chromium-review.googlesource.com/c/1252621
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596696}

TBR=nzolghadr@chromium.org,sahel@chromium.org

Change-Id: I7453b56f9ed1452839674e7d70d172e60c1440b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  884728 ,  249063 ,  892285 
Reviewed-on: https://chromium-review.googlesource.com/c/1262428
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596793}
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_browsertest.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_scheduler.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_scheduler.h
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_scheduler_android.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/fling_scheduler_android.h
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/mock_input_router_client.cc
[modify] https://crrev.com/0528108bb9a5b54b67af1d46ba708efff9f4f534/content/browser/renderer_host/input/mock_input_router_client.h

Components: Internals>Sandbox>SiteIsolation Internals>Input>Touch>Pad
It appears to be specific to viz_content_browsertests.

  [ RUN      ] BrowserSideFlingBrowserTest.TouchpadFlingBubblesFromOOPIF
  [21377:21384:1004/102303.259388:ERROR:network_service.cc(89)] Not implemented reached in std::unique_ptr<net::NetworkChangeNotifier> network::(anonymous namespace)::CreateNetworkChangeNotifierIfNeeded()
  DevTools listening on ws://127.0.0.1:34810/devtools/browser/6405cf2b-7e60-4e83-9a41-3a103aa9bde2
  [21377:21377:1004/102303.278652:ERROR:proxy_resolution_service.cc(1555)] ProxyConfigService for ChromeOS should be created in profile_io_data.cc::CreateProxyConfigService and this should be used only for examples.
  BrowserTestBase received signal: Terminated. Backtrace:
  #0 0x0000037ab36f base::debug::StackTrace::StackTrace()
  #1 0x0000032dfdb5 content::(anonymous namespace)::DumpStackTraceSignalHandler()
  #2 0x7f12c235ccb0 <unknown>
  #3 0x7f12c54ca3ad __libc_read
  #4 0x0000037c82b0 base::MessagePumpLibevent::OnWakeup()
  #5 0x0000037e8a2d event_base_loop
  #6 0x0000037c7ffb base::MessagePumpLibevent::Run()
  #7 0x000003721554 base::MessageLoop::Run()
  #8 0x0000037431f9 base::RunLoop::Run()
  #9 0x000000d0f2ca content::BrowserSideFlingBrowserTest::GiveItSomeTime()
  #10 0x000000d0fb4e content::BrowserSideFlingBrowserTest::WaitForOOPIFScroll()
  #11 0x000000d10047 content::BrowserSideFlingBrowserTest_TouchpadFlingBubblesFromOOPIF_Test::RunTestOnMainThread()
  #12 0x0000032df242 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #13 0x00000335e749 content::ShellBrowserMainParts::PreMainMessageLoopRun()
  #14 0x000002b5d691 content::BrowserMainLoop::PreMainMessageLoopRun()
  #15 0x000003010225 content::StartupTaskRunner::RunAllTasksNow()
  #16 0x000002b5bdc7 content::BrowserMainLoop::CreateStartupTasks()
  #17 0x000002b5ff33 content::BrowserMainRunnerImpl::Initialize()
  #18 0x00000334049d ShellBrowserMain()
  #19 0x0000033343a0 content::ShellMainDelegate::RunProcess()
  #20 0x000002a5bebc content::ContentMainRunnerImpl::Run()
  #21 0x000004dc77a5 service_manager::Main()
  #22 0x000001de3254 content::ContentMain()
  #23 0x0000032dee0b content::BrowserTestBase::SetUp()
  #24 0x000001a4cc2d testing::Test::Run()
  #25 0x000001a4d850 testing::TestInfo::Run()
  #26 0x000001a4dd67 testing::TestCase::Run()
  #27 0x000001a59b37 testing::internal::UnitTestImpl::RunAllTests()
  #28 0x000001a596ad testing::UnitTest::Run()
  #29 0x000003315f21 base::TestSuite::Run()
  #30 0x0000032d824a content::ContentTestLauncherDelegate::RunTestSuite()
  #31 0x0000032fc15c content::LaunchTests()
  #32 0x0000032d8210 main
  #33 0x7f12c2347f45 __libc_start_main
  #34 0x00000094608a _start
Oh, nevermind. It flaked on content_browsertests as well.
Cc: wjmaclean@chromium.org sahel@chromium.org
 Issue 895059  has been merged into this issue.
Mergedinto: 894703
Status: Duplicate (was: Untriaged)

Sign in to add a comment