Switch to new SkImage::makeColorSpace behavior |
|||||
Issue descriptionNow that Skia preserves colorType and alphaType of the original image in SkImage::makeColorSpace(), switch to the new behavior in Chrome.
,
Oct 5
,
Oct 5
,
Oct 5
We still need to check the new results for the pixel tests at https://pantheon.corp.google.com/storage/browser/chromium-gpu-archive/reference-images?pli=1&prefix=Pixel_CanvasDisplayLinearRGB.
,
Oct 9
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9000cbeeaad95898edf202d82e6360408fa6a1a commit e9000cbeeaad95898edf202d82e6360408fa6a1a Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Tue Oct 09 18:35:31 2018 Increase version number to enforce new results for the pixel tests This was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1262427 Bug: 892281 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I487b9edcef7573c67c4550d01c3142052a77fdf1 Reviewed-on: https://chromium-review.googlesource.com/c/1269939 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#598002} [modify] https://crrev.com/e9000cbeeaad95898edf202d82e6360408fa6a1a/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db4998593ebc1568a221b037604a2303c3e0ae75 commit db4998593ebc1568a221b037604a2303c3e0ae75 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Oct 10 21:09:31 2018 Remove self.Fails from color managed pixel tests Now that v5 test results are available in https://pantheon.corp.google.com/storage/browser/chromium-gpu-archive/reference-images?pli=1&prefix=Pixel_CanvasDisplayLinearRGB and match the expectations, we can remove the self.Fails from pixel_expectations.py TBR=fserb@chromium.org Bug: 892281 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4745218dd350c3a88a7cd83c1afb0507e159091a Reviewed-on: https://chromium-review.googlesource.com/c/1273271 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#598504} [modify] https://crrev.com/db4998593ebc1568a221b037604a2303c3e0ae75/content/test/gpu/gpu_tests/pixel_expectations.py
,
Oct 11
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 4