New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892281 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 634542
issue 884788



Sign in to add a comment

Switch to new SkImage::makeColorSpace behavior

Project Member Reported by zakerinasab@chromium.org, Oct 4

Issue description

Now that Skia preserves colorType and alphaType of the original image in SkImage::makeColorSpace(), switch to the new behavior in Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af97cea37146865455551fd6f656d482183ec38

commit 0af97cea37146865455551fd6f656d482183ec38
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu Oct 04 20:59:29 2018

Switch to new SkImage::makeColorSpace behavior

This preserves colorType and alphaType of the original image.

TBR=fserb@chromium.org

Bug:  892281 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iebd663cd45199ab7a22e5d98d671dbf54bee9fb3
Reviewed-on: https://chromium-review.googlesource.com/c/1262427
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596847}
[modify] https://crrev.com/0af97cea37146865455551fd6f656d482183ec38/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/0af97cea37146865455551fd6f656d482183ec38/skia/config/SkUserConfig.h

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Blocking: 884788
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9000cbeeaad95898edf202d82e6360408fa6a1a

commit e9000cbeeaad95898edf202d82e6360408fa6a1a
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Oct 09 18:35:31 2018

Increase version number to enforce new results for the pixel tests

This was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1262427

Bug:  892281 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I487b9edcef7573c67c4550d01c3142052a77fdf1
Reviewed-on: https://chromium-review.googlesource.com/c/1269939
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598002}
[modify] https://crrev.com/e9000cbeeaad95898edf202d82e6360408fa6a1a/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db4998593ebc1568a221b037604a2303c3e0ae75

commit db4998593ebc1568a221b037604a2303c3e0ae75
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Oct 10 21:09:31 2018

Remove self.Fails from color managed pixel tests

Now that v5 test results are available in
https://pantheon.corp.google.com/storage/browser/chromium-gpu-archive/reference-images?pli=1&prefix=Pixel_CanvasDisplayLinearRGB
and match the expectations, we can remove the self.Fails from pixel_expectations.py

TBR=fserb@chromium.org

Bug:  892281 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4745218dd350c3a88a7cd83c1afb0507e159091a
Reviewed-on: https://chromium-review.googlesource.com/c/1273271
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598504}
[modify] https://crrev.com/db4998593ebc1568a221b037604a2303c3e0ae75/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Fixed (was: Assigned)

Sign in to add a comment