make platform2 use COMMIT-QUEUE.ini |
|||
Issue descriptionChrome OS has support for Per-project Commit Queue (and Pre CQ) settings. These don't seem to be followed for packages within platform2/, and instead default to a catch-all configuration. Many projects (biod, hermes) don't need to run on all devices. Therefore, we should add support for COMMIT-QUEUE.ini in platform2. This can help reduce Pre CQ completion times, and also reduce the strain on builder resources. Assigning this to myself initially, but will CC build infra folks to direct me.
,
Oct 5
Jason, any suggestions? I've tried putting COMMIT-QUEUE configs in biod as well as in platform2/ but it doesn't seem to have an effect when I run a TryBot : https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1262235 Is there a list of directories for which COMMIT-QUEUE.ini is honored. Codesearch didn't show anything up.
,
Oct 5
I haven't really done much with COMMIT-QUEUE.ini. IIRC, a tryjob won't really show you anything since it doesn't actually commit code.
,
Oct 5
Hmm, so that means the COMMIT-QUEUE.ini changes won't take effect until the code is committed? In that case it might be worthwhile to just submit it and try :)
,
Oct 10
Seems to work! Marking closed. Next potential step: Is there a way we can make a "macro" of representative pre-cq builds that packages can use (if they just want a representative set, and not the more comprehensive pre CQ default config set). That way each individual package doesn't have to be updated to include the recent architectures. e.g we can have something like: lite-config: betty-pre-cq kevin-arcnext-no-vmtest-pre-cq eve-no-vmtest-pre-cq nocturne-no-vmtest-pre-cq The above can be defined in a common location (chromite/lib ?) and then individual packages can just reference that: biod/COMMIT-QUEUE.ini would be: pre-cq-config: lite-config |
|||
►
Sign in to add a comment |
|||
Comment 1 by pmalani@chromium.org
, Oct 4