New issue
Advanced search Search tips

Issue 892272 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 829435

Blocking:
issue 644851
issue 899750



Sign in to add a comment

SkiaRenderer doesn't work with SkDDL + passthrough decoder

Project Member Reported by penghuang@chromium.org, Oct 4

Issue description

How to repro:
Launch chrome with below command line:
out/linux_rel/chrome --enable-logging=stderr --user-data-dir=$(mktemp -d)  --use-gl=angle --use-angle=gl --use-cmd-decoder=passthrough --enable-features="VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList" 
 
Blocking: 898270
Labels: vulkanize
Labels: -vulkanize Proj-Vulkanize
Blocking: -898270 899750
backer@ has talked about implementing passthrough. Is that a separate bug? Or is this the bug for passthrough?
We have a bug for OOP-R with passthrough (issue 829435). There may be additional work to make SkiaRenderer + SkDDL work. 
Blocking: 644851
Blockedon: 829435
Cc: penghuang@chromium.org
Owner: backer@chromium.org
Status: Started (was: Assigned)
I have a short CL up to make it work with CPU raster. I've tested it with my OOP-R for passthrough prototype and that works as well.

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c649646549d03be00f4ba32f0f71eb14d51dac68

commit c649646549d03be00f4ba32f0f71eb14d51dac68
Author: Jonathan Backer <backer@chromium.org>
Date: Thu Nov 22 21:52:47 2018

Make SkRender,SkDDL work with passthrough decoder

Works with these flags on Linux build with DCHECKs enabled:

 --use-gl=angle --use-angle=gl --use-cmd-decoder=passthrough --enable-features="VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList"

Bug:  892272 
Change-Id: I48c2caec780a6243b58e3ed1b2c60240f7a3b213
Reviewed-on: https://chromium-review.googlesource.com/c/1348589
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610491}
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/components/viz/service/display/resource_metadata.h
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/components/viz/service/display_embedder/skia_output_surface_impl.cc
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/gpu/command_buffer/service/skia_utils.cc
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/gpu/command_buffer/service/skia_utils.h
[modify] https://crrev.com/c649646549d03be00f4ba32f0f71eb14d51dac68/gpu/ipc/service/gpu_channel_manager.cc

Status: Fixed (was: Started)

Sign in to add a comment