New issue
Advanced search Search tips

Issue 892230 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Permission Warnings are empty during extension installation

Reported by mate...@videolicious.com, Oct 4

Issue description

Chrome Version       : 69.0.3497.100 (Official Build) (64-bit)
OS Version .         : OS X 10.13.6

What steps will reproduce the problem?
1. Create internal(company accessible) extension with the manifest file such as this
{
  "name": "Videolicious",
  "short_name": "Videolicious",
  "description": "Videolicious is beautifully designed to make high quality video creation even easier and faster!",
  "version": "0.4",
  "minimum_chrome_version": "60",
  "permissions": [
    "https://mail.google.com/"
  ],
  "content_scripts": [{
    "matches": [
      "https://mail.google.com/*"
    ],
    "run_at": "document_end",
    "js": [
      "sdk/inboxsdk.js",
      "scripts/config.js",
      "scripts/main.js"
    ],
    "css": [
      "styles/main.css"
    ]
  }],
  "browser_action": {
    "default_icon": "img/icons/stars-512.png",
    "default_title": "Videolicious",
    "default_popup": "popup.html"
  },
  "icons": {
    "16": "img/icons/stars-512.png",
    "32": "img/icons/stars-512.png",
    "48": "img/icons/stars-512.png",
    "128": "img/icons/stars-512.png"
  },
  "web_accessible_resources": [
    "img/*"
  ],
  "manifest_version": 2
}

2. Go to the extension link and click "Add to Chrome" button
3. Permission Warnings popup is displayed showing a list of required permissions by extension

What is the expected result?
Permission warnings should display required gmail permission during extension installation.

What happens instead of that?
Permission warnings are empty.

I cannot find the way to solve and I rather suspect internal browser bug, because for 10 users only 1 can see this issue. The rest of the users can see a valid popup. Screenshoots attached.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36



 
image (16) (1).png
51.9 KB View Download
Screen Shot 2018-09-27 at 21.16.57.png
21.1 KB View Download
Cc: rdevlin....@chromium.org
Components: Platform>Extensions
Thanks for the report!

Are all the users on the same OS, and fetching the extension in the same way?  Does this reproduce reliably for the users that see it, or is it transitive for them as well?
Yes, all the users were using latest Mac OS 10.13.6 and right now it's updated to Mac OS 10.14. Users install extension via sharable link and they need to be logged in using company's email to access it.

The 1 user, that has experienced the issue could reproduce it 2-3 times by removing the extension and adding it once more. The list of extensions that were installed in his Chrome is visible in the attached file. However, I don't suspect other extensions to affect the issue in any way nor I could not reproduce it myself by installing the same extensions list in my Chrome.

Extensinos.jpeg
150 KB View Download
Labels: Needs-Triage-M69
Cc: susan.boorgula@chromium.org
Labels: Needs-Feedback Triaged-ET
mateusz@ Thanks for the update.

Request you to provide a sample extension where this issue can be reproduced, which will help in further triaging.

Thanks..
Cc: tapted@chromium.org ellyjo...@chromium.org
Status: Untriaged (was: Unconfirmed)
> The 1 user, that has experienced the issue could reproduce it 2-3 times by removing the extension and adding it once more.

After reproducing 2-3 times, did the problem go away?

This is interesting.  Chrome is detecting that the extension *did* have permissions (because the dialog says "It can:" rather than "needs no permissions").  Also strange is that in the bugged dialog, there's a horizontal separator - which I don't think the install dialog code ever adds.  It seems like somewhere, our UI code just messed up.  Unfortunately, without a repro, I'm not sure if there's a ton we can do here.

+UI experts tapted@ and ellyjones@ in case they have any thoughts.
I don't think that's a horizontal separator. I think that's an indication to say "this area is scrollable and there's a hidden line of text".

So the bug is that under some circumstances, the dialog as a whole is not sizing itself to cater for the expanded scrollview. Or, the contents got bigger, and a layout was performed without first increasing the size of the Widget.

A wild guess: possibly if the extension icon has not been loaded/converted it will start off at a smaller size, and then grow, requiring the title area to need more space.

I think the Add Extension dialog handrolls some of its dialog layout (see Issue 702196), and I saw someone mention somewhere that it needs a big cleanup.. This may just come out in the wash.
Components: UI
Status: Available (was: Untriaged)
This is obviously something we'd like to fix, but given it's only been seen very rarely and doesn't have reliable repro, marking as available for now.

If anyone on the UI team has some bandwidth to check it out, please grab it!
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
**UI mass Triage**

As per C#7, adding appropriate labels.

Sign in to add a comment