git cl upload failure on macOS 10.14
Reported by
eugene70...@gmail.com,
Oct 4
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15 Steps to reproduce the problem: 1. use macOS 10.14 2. "git commit -a" after changed any source file 3. "git cl upload" What is the expected behavior? What went wrong? ** Presubmit ERRORS ** check_blink_style.py failed Traceback (most recent call last): File "//third_party/blink/tools/check_blink_style.py", line 47, in <module> sys.exit(CheckWebKitStyle().main()) File "//third_party/blink/tools/blinkpy/style/main.py", line 128, in main host = Host() File "///third_party/blink/tools/blinkpy/common/host.py", line 46, in __init__ SystemHost.__init__(self) File "/Users/eugene/chromium/src/third_party/blink/tools/blinkpy/common/system/system_host.py", line 46, in __init__ self.user = User() File "//third_party/blink/tools/blinkpy/common/system/user.py", line 50, in __init__ self._platform_info = platform_info or PlatformInfo(sys, platform, FileSystem(), Executive()) File "//third_party/blink/tools/blinkpy/common/system/platform_info.py", line 56, in __init__ self.os_version = self._determine_mac_version(platform_module.mac_ver()[0]) File "//third_party/blink/tools/blinkpy/common/system/platform_info.py", line 150, in _determine_mac_version assert 9 <= minor_release <= 13, 'Unsupported mac OS version: %s' % mac_version_string AssertionError: Unsupported mac OS version: 10.14 Did this work before? N/A Chrome version: <Copy from: 'about:version'> Channel: n/a OS Version: OS X 10.14 Flash Version: //third_party/blink/tools/blinkpy/common/system/platform_info.py is not support macOS 10.14 yet.
,
Oct 8
,
Oct 20
,
Oct 25
,
Oct 25
,
Oct 25
,
Nov 6
eugene70kim@ Thanks for the issue. This issue is out of scope of triaging at TE end as it is related to Infra. Hence adding 'TE-NeedsTriageHelp' label and requesting 'Blink>Infra' team to look into the issue and help in further triaging. Thanks..
,
Nov 6
CC jeffcarp@chromium.org, a familiar name from //third_party/blink/tools/OWNERS.
,
Nov 6
git cl is part of depot_tools, moving to that component
,
Nov 6
Blink infra team to decide about support for macOS 10.14
,
Nov 7
Blink Infra should support the latest version of macOS AFAIK.
,
Nov 9
Who on blink is the right person to update the OS support?
,
Nov 9
,
Nov 9
I'm not sure. CCing third_party/WebKit/Tools OWNER tkent@ who has the most commits recently in that directory.
,
Nov 12
,
Nov 12
Mac triage: assigning to dpranke@ - I think this is still live.
,
Nov 13
Actually, yoink - I need to look into this to get webkit tests passing on 10.14 anyway.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47096f4a10e6e92c57aab95c5cc4b4be00f6ed88 commit 47096f4a10e6e92c57aab95c5cc4b4be00f6ed88 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Nov 13 18:42:49 2018 blink: support mac 10.14 in python libraries This change: 1) Has platform_info not assert that 10.14 is unsupported 2) Has the web_tests baseline code handle 10.14 (right now the same way it handles 10.13) The second change is almost certainly wrong but this gets run_blinkpy_tests green locally. Bug: 892229 Change-Id: Iae1188879f8496aa03fd060ed5590c841515a2c8 Reviewed-on: https://chromium-review.googlesource.com/c/1333567 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607670} [modify] https://crrev.com/47096f4a10e6e92c57aab95c5cc4b4be00f6ed88/third_party/blink/tools/blinkpy/common/system/platform_info.py [modify] https://crrev.com/47096f4a10e6e92c57aab95c5cc4b4be00f6ed88/third_party/blink/tools/blinkpy/web_tests/port/mac.py
,
Nov 14
Is this fixed for folks now? I think it should be. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by swarnasree.mukkala@chromium.org
, Oct 5