New issue
Advanced search Search tips

Issue 892203 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocking:
issue 891834



Sign in to add a comment

Use EmbeddedTestServer instead of web::HttpServer in automation_action_egtest.mm

Project Member Reported by eugene...@chromium.org, Oct 4

Issue description

web::HttpServer is deprecated in favor of net::EmbeddedTestServer:
https://docs.google.com/document/d/1tTnjQIvN3gaF4iM3NI9NxHM7hBSHiVIBesssJxyq63I/edit?ts=5970bfd9


 
Blocking: 891834
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc0ed7a6e2cf966355dce9b6e5e4409de41486e

commit 1dc0ed7a6e2cf966355dce9b6e5e4409de41486e
Author: Eric Aleshire <ericale@google.com>
Date: Tue Dec 18 23:44:04 2018

Use EmbeddedTestServer instead of web::HttpServer.

Small code cleanup (see attached bug).
Uses //src/ios/web_view/shell/test/shell_egtest.mm as a model.

Bug: 892203
Change-Id: Ia1f9c5c2c42dbc63244c50f00347417ae74a2231
Reviewed-on: https://chromium-review.googlesource.com/c/1377316
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617673}
[delete] https://crrev.com/5ea1d6cc04ee3146d6866f8a6b3ee58d0e1c246e/ios/chrome/browser/autofill/automation/DEPS
[modify] https://crrev.com/1dc0ed7a6e2cf966355dce9b6e5e4409de41486e/ios/chrome/browser/autofill/automation/automation_action_egtest.mm

Sign in to add a comment