Issue metadata
Sign in to add a comment
|
1% regression in media.desktop at 592922:593051 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 4
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/10ebc5c4e40000
,
Oct 4
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16dc688ce40000
,
Oct 5
📍 Found significant differences after each of 4 commits. https://pinpoint-dot-chromeperf.appspot.com/job/10ebc5c4e40000 [Media Controls] Move doubletap handling to MediaControlsImpl by steimel@chromium.org https://chromium.googlesource.com/chromium/src/+/2dfe550c2ef6712eecc39e0702246d27648bb646 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.838e+07 → 2.868e+07 (+2.949e+05) Fix DCHECK when entering fullscreen on Linux with the GTK theme by thomasanderson@chromium.org https://chromium.googlesource.com/chromium/src/+/95c86a6c8f719aca3484b4080c56cb2c7e1757d8 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.868e+07 → 2.861e+07 (-6.932e+04) fix some TabDragController test for Mash by mukai@chromium.org https://chromium.googlesource.com/chromium/src/+/6afac0314ce61cca7fc900430635233932547f72 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.861e+07 → 2.867e+07 (+6.881e+04) Web UI Polymer2: Run browser_tests with 4 shards by rbpotter@chromium.org https://chromium.googlesource.com/chromium/src/+/17dd68a5ecc45d3dd94609dcb31a0ea4f8c87d31 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.867e+07 → 2.825e+07 (-4.276e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Oct 5
📍 Found significant differences after each of 4 commits. https://pinpoint-dot-chromeperf.appspot.com/job/16dc688ce40000 [Media Controls] Move doubletap handling to MediaControlsImpl by steimel@chromium.org https://chromium.googlesource.com/chromium/src/+/2dfe550c2ef6712eecc39e0702246d27648bb646 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.838e+07 → 2.859e+07 (+2.059e+05) Fix DCHECK when entering fullscreen on Linux with the GTK theme by thomasanderson@chromium.org https://chromium.googlesource.com/chromium/src/+/95c86a6c8f719aca3484b4080c56cb2c7e1757d8 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.875e+07 → 2.836e+07 (-3.954e+05) fix some TabDragController test for Mash by mukai@chromium.org https://chromium.googlesource.com/chromium/src/+/6afac0314ce61cca7fc900430635233932547f72 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.836e+07 → 2.875e+07 (+3.949e+05) Roll src/third_party/depot_tools 7e301cfffe7f..92df4e63abbe (1 commits) by chromium-autoroll@skia-public.iam.gserviceaccount.com https://chromium.googlesource.com/chromium/src/+/bcbe1a6c13b714197b3f558ecc429625a210c400 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 2.867e+07 → 2.861e+07 (-6.144e+04) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
,
Oct 5
Reporter: What exactly does this benchmark indicate? Note that my CL listed in comment 4 only changes a test configuration for browser_tests.
,
Oct 8
+crouleau I think the benchmark is for memory usage by all processes when playing a video.
,
Oct 8
Okay, unassigning myself, as it seems very unlikely that a test configuration change would impact this benchmark.
,
Oct 8
-Myself, +Doug to answer any questions about media.desktop.
,
Oct 8
,
Oct 9
Based on the metric:ChromiumPerf/Win 7 Nvidia GPU Perf/media.desktop / memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg / This is a 1% memory regression in all of Chrome. Looks like noise. Closing as Won't Fix. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 4