InitSDK changes are Workspace incompatible. |
||
Issue descriptionWorkspace builders are currently using the standard InitSDK stage, against the workspace checkout, which is often on a different branch from cbuildbot. Recent changes to how cros_sdk is invoked, are broken on older branches, generating errors like: cros_sdk: error: no such option: --buildbot-log-version
,
Oct 4
Flag incompatibility on branches is a problem we're going to have to deal with one way or another. The two ideas I've had are: 1) gate flags on some kind of workspace version detection (tricky with backports) 2) parse --help to detect available flags (terrible but probably effective)
,
Oct 4
We have an "api-version" mechanism for cbuildbot arguments, but it's too awkward for this.
,
Oct 4
I want to think about this a lot more. For now, I think having "Workspace" stages use a minimum of arguments, and maybe comparing branch version numbers to decide which arguments to use should be sufficient. But only if we work on a better plan.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/bfe2f84a725dbb103c513d0002eed95a1d72dfc9 commit bfe2f84a725dbb103c513d0002eed95a1d72dfc9 Author: Don Garrett <dgarrett@google.com> Date: Fri Oct 05 22:43:33 2018 firmwarebranch: Use WorkspaceInitSDK. The TOT InitSDKStage uses command line options that may or may not exist on older branches, so switch to the more minimal WorkspaceInitSDK stage. BUG= chromium:892186 TEST=run_tests Change-Id: Ifdd50608342182f240dfb0150405e7deca88d322 Reviewed-on: https://chromium-review.googlesource.com/1262176 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Alex Klein <saklein@chromium.org> [modify] https://crrev.com/bfe2f84a725dbb103c513d0002eed95a1d72dfc9/cbuildbot/builders/workspace_builders.py
,
Oct 5
Hopefully fixed, verification builds are running now.
,
Oct 8
|
||
►
Sign in to add a comment |
||
Comment 1 by dgarr...@chromium.org
, Oct 4