New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Linux FYI Release (Intel HD 630) failing many tests

Project Member Reported by kylec...@chromium.org, Oct 4

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20(Intel%20HD%20630)

It looks like all tests that run Chrome are failing. See this run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Release%20%28Intel%20HD%20630%29/6213

The crash in some bluetooth init code:
	 0  chrome!Init [bluetooth_adapter_client.cc : 473 + 0x0]
	    rax = 0x0000000000000000   rdx = 0x00007ffeb632d530
	    rcx = 0x000012df0e904468   rbx = 0x000012df0eaeb1b0
	    rsi = 0x00007ffeb632d4c0   rdi = 0x00007ffeb632d4e0
	    rbp = 0x00007ffeb632d520   rsp = 0x00007ffeb632d4c0
	     r8 = 0x000015edb632d230    r9 = 0x000015edb632d3f8
	    r10 = 0x000012df0f290b18   r11 = 0x00007f5ce5d563b0
	    r12 = 0x00007ffeb632d4e0   r13 = 0x0000000000000000
	    r14 = 0x00007ffeb632d530   r15 = 0x0000000000000000
	    rip = 0x000055afaaa1f5c1
	    Found by: given as instruction pointer in context
	 1  chrome!InitializeClients [bluez_dbus_manager.cc : 227 + 0x9]
	    rbx = 0x000012df0eabe340   rbp = 0x00007ffeb632d560
	    rsp = 0x00007ffeb632d530   r12 = 0x000055afaaa40210
	    r13 = 0x0000000000000000   r14 = 0x00007ffeb632d530
	    r15 = 0x0000000000000000   rip = 0x000055afaaa401ee
	    Found by: call frame info
	 2  chrome!OnObjectManagerSupported [bluez_dbus_manager.cc : 177 + 0x8]
	    rbx = 0x000012df0f215d20   rbp = 0x00007ffeb632d6c0
	    rsp = 0x00007ffeb632d570   r12 = 0x000055afaaa40210
	    r13 = 0x0000000000000000   r14 = 0x000012df0eabe340
	    r15 = 0x0000000000000000   rip = 0x000055afaaa402c6
	    Found by: call frame info
	 3  chrome!Run [bind_internal.h : 516 + 0x17]
	    rbx = 0x000012df0eacdf80   rbp = 0x00007ffeb632d830
	    rsp = 0x00007ffeb632d6d0   r12 = 0x000055afaaa40210
	    r13 = 0x0000000000000000   r14 = 0x000012df0eb2a860
	    r15 = 0x000012df0eacdfb0   rip = 0x000055afa700854c
	    Found by: call frame info
	 4  chrome!RunOnce [callback.h : 99 + 0x6]
	    rbx = 0x000012df0eb2a860   rbp = 0x00007ffeb632d9a0
	    rsp = 0x00007ffeb632d840   r12 = 0x000012df0eb2a860
	    r13 = 0x00007ffeb632db30   r14 = 0x0000000031e478e7
	    r15 = 0x0000000000000000   rip = 0x000055afaaaa8f77
	    Found by: call frame info
	 5  chrome!RunResponseOrErrorCallback [callback.h : 99 + 0x9]
	    rbx = 0x000012df0e8e9340   rbp = 0x00007ffeb632db20
	    rsp = 0x00007ffeb632d9b0   r12 = 0x000012df0eb2a860
	    r13 = 0x00007ffeb632db30   r14 = 0x0000000031e478e7
	    r15 = 0x0000000000000000   rip = 0x000055afaaaa4ef4
	    Found by: call frame info
	 6  chrome!Invoke<void (dbus::ObjectProxy::*)(dbus::ObjectProxy::ReplyCallbackHolder, base::TimeTicks, dbus::Response *, dbus::ErrorResponse *), scoped_refptr<dbus::ObjectProxy>, dbus::ObjectProxy::ReplyCallbackHolder, base::TimeTicks, dbus::Response *, dbus::ErrorResponse *> [bind_internal.h : 516 + 0x6]
	    rbx = 0x00007ffeb632db30   rbp = 0x00007ffeb632dca0
	    rsp = 0x00007ffeb632db30   r12 = 0x000055afaaaa4df0
	    r13 = 0x0000000000000000   r14 = 0x00007ffeb632de48
	    r15 = 0x000012df0eaca4c8   rip = 0x000055afaaaa988e
	    Found by: call frame info

Looks like it's https://crrev.com/c/1215427 that's causing this. Reverting locally fixes it for me, although https://crrev.com/c/1215427 needs to be reverted as well since it landed on top.
 
https://crrev.com/c/1250581 is the CL that landed on top of https://crrev.com/c/1215427 .
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40ceb08df809a852a986f97c4e5d23c475fdb060

commit 40ceb08df809a852a986f97c4e5d23c475fdb060
Author: kylechar <kylechar@chromium.org>
Date: Thu Oct 04 15:42:28 2018

Revert "bluetooth: Finish implementing GetState()"

This reverts commit 6d46cb2853ea7a30eb2752d01f851450e136d8f0.

Reason for revert: Crash on startup.  https://crbug.com/892182 

Original change's description:
> bluetooth: Finish implementing GetState()
> 
> Use Adapter's power state for GetState().
> 
> Bug: 870192
> Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637
> Reviewed-on: https://chromium-review.googlesource.com/c/1250581
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596532}

TBR=reillyg@chromium.org,ortuno@chromium.org

Change-Id: Ib6da2c1e13a03a86d8daf88eba89ea53d8bd9e45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870192,  892182 
Reviewed-on: https://chromium-review.googlesource.com/c/1261918
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596684}
[modify] https://crrev.com/40ceb08df809a852a986f97c4e5d23c475fdb060/services/device/bluetooth/bluetooth_system.cc
[modify] https://crrev.com/40ceb08df809a852a986f97c4e5d23c475fdb060/services/device/bluetooth/bluetooth_system_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/467e19a62cd2826f933b18930e71d56d97ca7cd3

commit 467e19a62cd2826f933b18930e71d56d97ca7cd3
Author: kylechar <kylechar@chromium.org>
Date: Thu Oct 04 15:44:41 2018

Revert "bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState"

This reverts commit 837b3c2074fca77f66fda4c08d7c65a2b5b762ef.

Reason for revert: Crash on startup.  https://crbug.com/892182 

Original change's description:
> bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState
> 
> There are two parts to this change:
> 
> 1. Create a new BluetoothAdapterClient instance. For this we add
>    "alternate_bluetooth_adapter_client()" to the bundle of DBus clients.
>    This new instance uses a separate DBus Connection through
>    BluezDBusThreadManager. This ensures actions on one client won't
>    affect the other client.
> 
> 2. Implement BluetoothSystem::GetState using the new client.
> 
> Bug: 870192,  882771 
> Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201
> Reviewed-on: https://chromium-review.googlesource.com/c/1215427
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596520}

TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org,ortuno@chromium.org,sonnysasaka@chromium.org

Change-Id: Icf5a244f163152ccc41d84f7ea43220afebae791
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870192,  882771 ,  892182 
Reviewed-on: https://chromium-review.googlesource.com/c/1261878
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596685}
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/device/bluetooth/dbus/bluetooth_dbus_client_bundle.cc
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/device/bluetooth/dbus/bluetooth_dbus_client_bundle.h
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/device/bluetooth/dbus/bluez_dbus_manager.cc
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/device/bluetooth/dbus/bluez_dbus_manager.h
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/services/device/bluetooth/BUILD.gn
[delete] https://crrev.com/40ceb08df809a852a986f97c4e5d23c475fdb060/services/device/bluetooth/DEPS
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/services/device/bluetooth/bluetooth_system.cc
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/services/device/bluetooth/bluetooth_system.h
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/services/device/bluetooth/bluetooth_system_unittest.cc
[modify] https://crrev.com/467e19a62cd2826f933b18930e71d56d97ca7cd3/services/device/public/mojom/bluetooth_system.mojom

Will wait and see if the bot cycles green.
Also ortuno here is a better stack trace if you need to debug this:

  [ RUN      ] CastStreamingApiTestWithPixelOutput.EndToEnd/0
  [2475:2475:1004/023729.149574:WARNING:password_store_factory.cc(261)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
  ATTENTION: default value of option force_s3tc_enable overridden by environment.
  [2508:2508:1004/023729.162775:INFO:GrGLInterface.cpp(453)] ../../third_party/skia/src/gpu/gl/GrGLInterface.cpp:453 GrGLInterface::validate() failed.
  [2475:2475:1004/023729.199185:ERROR:x11_input_method_context_impl_gtk.cc(144)] Not implemented reached in virtual void libgtkui::X11InputMethodContextImplGtk::SetSurroundingText(const base::string16 &, const gfx::Range &)
  BrowserTestBase received signal: Segmentation fault. Backtrace:
  #0 0x0000068718af base::debug::StackTrace::StackTrace()
  #1 0x000006eb8ff5 content::(anonymous namespace)::DumpStackTraceSignalHandler()
  #2 0x7fe90ba6e7f0 <unknown>
  #3 0x000007ff04b1 bluez::BluetoothAdapterClientImpl::Init()
  #4 0x000008010fbe bluez::BluezDBusManager::InitializeClients()
  #5 0x000008011096 bluez::BluezDBusManager::OnObjectManagerSupported()
  #6 0x000002fedebc _ZN4base8internal7InvokerINS0_9BindStateIMN12_GLOBAL__N_120WebUIMessageListenerEFvPKNS_9ListValueEEJNS_7WeakPtrIS4_EEEEEFvS7_EE3RunEPNS0_13BindStateBaseES7_
  #7 0x000008079c17 _ZN4base8internal7InvokerINS0_9BindStateIZN4dbus11ObjectProxy27CallMethodWithErrorCallbackEPNS3_10MethodCallEiNS_12OnceCallbackIFvPNS3_8ResponseEEEENS7_IFvPNS3_13ErrorResponseEEEEE3$_0JSB_SF_EEEFvS9_SD_EE7RunOnceEPNS0_13BindStateBaseES9_SD_
  #8 0x000008075b94 dbus::ObjectProxy::RunResponseOrErrorCallback()
  #9 0x00000807a52e _ZN4base8internal13FunctorTraitsIMN4dbus11ObjectProxyEFvNS3_19ReplyCallbackHolderENS_9TimeTicksEPNS2_8ResponseEPNS2_13ErrorResponseEEvE6InvokeISB_13scoped_refptrIS3_EJS4_S5_S7_S9_EEEvT_OT0_DpOT1_
  #10 0x00000807a450 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus11ObjectProxyEFvNS4_19ReplyCallbackHolderENS_9TimeTicksEPNS3_8ResponseEPNS3_13ErrorResponseEEJ13scoped_refptrIS4_ES5_S6_S8_SA_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
  #11 0x00000683da5b base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
  #12 0x00000683dece _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
  #13 0x0000067c4e4d base::debug::TaskAnnotator::RunTask()
  #14 0x0000067c3d3e base::MessageLoop::RunTask()
  #15 0x0000067c4142 base::MessageLoop::DoWork()
  #16 0x0000067c7eb9 base::MessagePumpGlib::Run()
  #17 0x0000067c3811 base::MessageLoop::Run()
  #18 0x0000067efc96 base::RunLoop::Run()
  #19 0x000006ee3f65 content::RunAllPendingInMessageLoop()
  #20 0x0000068be235 InProcessBrowserTest::PreRunTestOnMainThread()
  #21 0x000006eb8239 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #22 0x000006925dc4 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
  #23 0x00000692490a ChromeBrowserMainParts::PreMainMessageLoopRun()
  #24 0x000004a97891 content::BrowserMainLoop::PreMainMessageLoopRun()
  #25 0x000004fa0cd5 content::StartupTaskRunner::RunAllTasksNow()
  #26 0x000004a95d99 content::BrowserMainLoop::CreateStartupTasks()
  #27 0x000004a9a723 content::BrowserMainRunnerImpl::Initialize()
  #28 0x000004a934c2 content::BrowserMain()
  #29 0x00000670ffda content::ContentMainRunnerImpl::Run()
  #30 0x0000089e3509 service_manager::Main()
  #31 0x00000670e1d1 content::ContentMain()
  #32 0x000006eb7e9d content::BrowserTestBase::SetUp()
  #33 0x0000068bcaed InProcessBrowserTest::SetUp()
  #34 0x000003bba7fd testing::Test::Run()
  #35 0x000003bbb460 testing::TestInfo::Run()
  #36 0x000003bbb977 testing::TestCase::Run()
  #37 0x000003bc7b97 testing::internal::UnitTestImpl::RunAllTests()
  #38 0x000003bc770d testing::UnitTest::Run()
  #39 0x0000068d4951 base::TestSuite::Run()
  #40 0x000006796d5a ChromeTestSuiteRunner::RunTestSuite()
  #41 0x000006edffe5 content::LaunchTests()
  #42 0x000006797200 LaunchChromeTests()
  #43 0x000006796cde main
  #44 0x7fe90ba593f1 __libc_start_main
  #45 0x00000261602a _start

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933607224014221696/+/steps/tab_capture_end2end_tests_on_Intel_GPU_on_Linux_on_Ubuntu/0/logs/CastStreamingApiTestWithPixelOutput.EndToEnd__x2f_0/0
Thank you Kyle for catching this!

I think we should add at least some GPU tests running on Linux/Intel to the CQ (linux_chromium_rel_ng). Maybe the faster-running ones, and maybe not all of webgl_conformance. Could you think about this a bit and perhaps file a bug? Thanks!

Status: Fixed (was: Assigned)
Bot went green after the reverts landed. I'll file a bug about Linux/Intel in CQ tomorrow too.
I have a fix for the crash but I would like to run the CL through some bots to make sure the tests don't break again. Are there any trybots that run this set of tests?
Yes. Manually running the linux_optional_gpu_tests_rel tryserver will run a sufficient number of tests to ensure that this is fixed. Kyle will work on getting a baseline set of tests running on the default Chromium CQ bots.

Sign in to add a comment