These are browser_tests that link with all of chrome. They should be in browser_tests.
James said he would look into doing this.
Note that https://chromium-review.googlesource.com/c/chromium/src/+/1226357 does this; you'd want to follow that pattern. Would be great if this policy were applied consistently for all targets rather than getting singled out here.
It's "speak" not "speech" btw. The target is select_to_speak_extension_tests. Thanks James.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1380ad16565e3009b4b87269f98551da753a2ddc commit 1380ad16565e3009b4b87269f98551da753a2ddc Author: James Cook <jamescook@chromium.org> Date: Thu Oct 25 00:51:19 2018 Fold chromevox_tests into browser_tests chromevox_tests compiles and links all of chrome, so folding into browser_tests will save work on the bots. It will also give coverage for SingleProcessMash and other projects that run browser_tests with optional flags. Rename the tests to start with ChromeVox to make them easier to run with --gtest_filter (thanks to dtseng for a CL that did the rename). Fix ChromeVoxEditingTest.RichTextSelectByLine so it isn't sensitive to exact font widths and remove chromevox_tests fontconfig override. Bug: 892179 , 898213 Test: browser_tests Change-Id: Ia23c8f4c237677d299bbe774cf3191654974a56b Reviewed-on: https://chromium-review.googlesource.com/c/1294811 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602543} [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/BUILD.gn [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/pan_strategy_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/aria_util_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/braille_text_handler_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/content_editable_extractor_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/cursor_selection_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/dom_util_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/find_util_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/page_selection_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/selection_util_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/spannable_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background_test.extjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/group_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/object_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/sentence_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/structural_line_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/table_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/word_walker_test.unitjs [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/test/BUILD.gn [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/docs/accessibility/chromevox.md [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/docs/accessibility/tests.md [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/chromium.memory.json [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b880df2ddfef8ee215b80b53d5376b808b6ac327 commit b880df2ddfef8ee215b80b53d5376b808b6ac327 Author: James Cook <jamescook@chromium.org> Date: Fri Oct 26 01:11:53 2018 Move select_to_speak_extension_tests into browser_tests select_to_speak_extension_tests compiles and links all of chrome, so folding into browser_tests will save work on the bots. It will also give coverage for SingleProcessMash and other projects that run browser_tests with optional flags. Bug: 892179 Change-Id: I8dfce56a8b522194dfbb0d24de7cb8f5cdd45b01 Reviewed-on: https://chromium-review.googlesource.com/c/1300073 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#602964} [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/chrome/test/BUILD.gn [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/docs/accessibility/tests.md [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/chromium.memory.json [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/b880df2ddfef8ee215b80b53d5376b808b6ac327/testing/buildbot/test_suites.pyl
zhelfins is taking care of switch_access_tests.
Comment 1 by sky@chromium.org
, Oct 22Owner: jamescook@chromium.org