shell_dialogs_unittests fail on 10.14 |
||
Issue descriptionBot: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/mac-osxbeta-rel Failing run: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/mac-osxbeta-rel/69 Failure log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933611326168921680/+/steps/shell_dialogs_unittests_on_Intel_GPU_on_Mac_on_Mac-10.14/0/stdout Tests: SelectFileDialogMacTest.DefaultPath
,
Nov 2
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a3be8ba02dcdb36bd769981ce6e73406130c9d commit 67a3be8ba02dcdb36bd769981ce6e73406130c9d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Nov 08 16:38:09 2018 shell_dialogs: fix SelectFileDialogMacTest on Mojave On 10.14, a file selection dialog whose default path doesn't exist will default back to ~/Documents, which breaks this test. To avoid this issue, have this test use /private/var, which is always present. Bug: 892174 Change-Id: I3f50a74566bdc5a3bf4eb14433138e65d1cfe2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1316109 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#606493} [modify] https://crrev.com/67a3be8ba02dcdb36bd769981ce6e73406130c9d/ui/shell_dialogs/select_file_dialog_mac_unittest.mm
,
Nov 12
These tests are fixed now. |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Oct 19Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)