New issue
Advanced search Search tips

Issue 892173 link

Starred by 1 user
Status: Fixed
Owner:
xiy...@chromium.org
Closed: Nov 6
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 874089



Sign in to add a comment

single_process_mash_content_browsertests sometime fails on startup

Project Member Reported by xiy...@chromium.org, Oct 4 
Example build:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/14176

shard #1 hits this and fails completely. None of the tests are properly started. The failure typically goes like this:

[ RUN      ] AccessibilityActionBrowserTest.CanvasGetImageScale
[10782:10813:1003/060855.698767:ERROR:network_service.cc(89)] Not implemented reached in std::unique_ptr<net::NetworkChangeNotifier> network::(anonymous namespace)::CreateNetworkChangeNotifierIfNeeded()
[1/598] AccessibilityActionBrowserTest.CanvasGetImageScale (TIMED OUT)

I suspect we stuck in the display wait loop in [1].

[1] https://cs.chromium.org/chromium/src/ui/wm/test/wm_test_helper.cc?rcl=acf7561e68abcb51470fe1afcd66b4fbb8c27128&l=103
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/654004bde584226461f6aa93adbd8da95659d045

commit 654004bde584226461f6aa93adbd8da95659d045
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Fri Oct 05 16:01:41 2018

mash: Speculative fix for content_browsertests hang

Speculative fix to single process mash content_browsertests
start-up hang by allowing nested task while waiting for display.

Bug:  892173 
Change-Id: Ia146293d8f2553cd8233feae80786e56402c7c55
Reviewed-on: https://chromium-review.googlesource.com/c/1262925
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597150}
[modify] https://crrev.com/654004bde584226461f6aa93adbd8da95659d045/ui/wm/test/wm_test_helper.cc
[modify] https://crrev.com/654004bde584226461f6aa93adbd8da95659d045/ui/wm/test/wm_test_helper.h

Comment 2 by sky@chromium.org, Nov 5

Labels: Pri-2

Comment 3 by xiy...@chromium.org, Nov 6

Status: Fixed (was: Assigned)
Problem not observed for a while. Marking as fixed.
►

Sign in to add a comment