New issue
Advanced search Search tips

Issue 892172 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 892168



Sign in to add a comment

mac_installer_unittests fail on 10.14

Project Member Reported by linds...@chromium.org, Oct 4

Issue description

Cc: -ellyjo...@chromium.org
Labels: Target-72 M-72
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/351c48cef04e7de7a328fbf12086238e29f53399

commit 351c48cef04e7de7a328fbf12086238e29f53399
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Nov 08 17:31:12 2018

mac: remove standalone installer app

This change removes //chrome/installer/mac/app. This directory contained a
cancelled project from 2016 to build a standalone installer and has never been
shipped. Since its tests are broken on 10.14, we can just delete it rather than
fixing those.

Bug:  892172 
Change-Id: Ib3d9e9c072a12e66cb7863a3e40eed8a13e948d6
Reviewed-on: https://chromium-review.googlesource.com/c/1315954
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606514}
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/chrome/installer/mac/BUILD.gn
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/AppDelegate.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/AppDelegate.mm
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/AuthorizedInstall.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/AuthorizedInstall.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/BUILD.gn
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/Downloader.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/Downloader.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/Info.plist
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/InstallerWindowController.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/InstallerWindowController.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/MainMenu.xib
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/NSAlert+ChromeInstallerAdditions.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/NSError+ChromeInstallerAdditions.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OWNERS
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaCommunication.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaCommunication.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaXMLParser.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaXMLParser.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaXMLRequest.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/OmahaXMLRequest.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/README.md
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/SystemInfo.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/SystemInfo.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/Unpacker.h
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/Unpacker.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/copy_to_disk.sh
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/main.m
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/testing/SystemInfo_test.mm
[delete] https://crrev.com/2429b3291ae78971bd6478bacf7c75db857ba961/chrome/installer/mac/app/testing/Unpacker_test.mm
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/351c48cef04e7de7a328fbf12086238e29f53399/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
These tests are deleted now so they are not failing :)

Sign in to add a comment