Hey Elly, could you take a look at these test failures?

Removing iOS, sorry

The NextAction date has arrived: 2018-10-05

This one goes over to mark@ I think. The logs look like this:

[ RUN      ] ProcessReaderMac.ChildOneThread
../../third_party/crashpad/crashpad/snapshot/mac/process_reader_mac_test.cc:316: Failure
Expected: (iterator) != (thread_map->end()), actual: 8-byte object <38-49 D7-EC FE-7F 00-00> vs 8-byte object <38-49 D7-EC FE-7F 00-00>
Stack trace:
0   crashpad_tests                      0x0000000103106b2b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   crashpad_tests                      0x00000001031064e9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   crashpad_tests                      0x0000000102f89c5d crashpad::test::(anonymous namespace)::ExpectSeveralThreads(std::__1::map<unsigned long long, crashpad::test::(anonymous namespace)::TestThreadPool::ThreadExpectation, std::__1::less<unsigned long long>, std::__1::allocator<std::__1::pair<unsigned long long const, crashpad::test::(anonymous namespace)::TestThreadPool::ThreadExpectation> > >*, std::__1::vector<crashpad::ProcessReaderMac::Thread, std::__1::allocator<crashpad::ProcessReaderMac::Thread> > const&, bool) + 1453
3   crashpad_tests                      0x0000000102f8bdcb crashpad::test::(anonymous namespace)::ProcessReaderThreadedChild::MachMultiprocessParent() + 907
4   crashpad_tests                      0x0000000103258683 crashpad::test::MachMultiprocess::MultiprocessParent() + 6803
5   crashpad_tests                      0x00000001032546e7 crashpad::test::Multiprocess::RunParent() + 87
6   crashpad_tests                      0x0000000103253ef2 crashpad::test::Multiprocess::Run() + 930
7   crashpad_tests                      0x0000000103256415 crashpad::test::MachMultiprocess::Run() + 277
8   crashpad_tests                      0x0000000102f8ba30 crashpad::test::(anonymous namespace)::ProcessReaderMac_ChildOneThread_Test::TestBody() + 48

Some cursory debugging of the test shows that the ThreadMap in ExpectSeveralThreads() does indeed contain a different single thread than the expected one.

ProcessReaderMac.ChildSeveralThreads fails the same way.

I was waiting for them to fix this in time for the release, but I guess that didn’t happen.