New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892156 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Remove enable-ephemeral-flash-permission flag

Project Member Reported by laforge@google.com, Oct 4

Issue description

The feature appears to be working as expected.  We should remove chrome://flags/#enable-ephemeral-flash-permission.
 
Cc: hkamila@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c

commit 6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Oct 12 19:06:53 2018

Remove chrome://flags/#enable-ephemeral-flash-permission.

Bug:  892156 
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599317}
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/about_flags.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c/components/content_settings/core/common/BUILD.gn
[delete] https://crrev.com/9d5b70e14dc71676de894f4d3477ac70db42a97f/components/content_settings/core/common/features.cc
[delete] https://crrev.com/9d5b70e14dc71676de894f4d3477ac70db42a97f/components/content_settings/core/common/features.h

Labels: Merge-Request-71
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 13

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M71 branch #3578 ASAP so we can pick it up for next M71 dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 15

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35

commit 4395f04f508278cd70be5ea2c1b6adcb4ddfcb35
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Oct 15 08:27:22 2018

Remove chrome://flags/#enable-ephemeral-flash-permission.

Bug:  892156 
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599317}(cherry picked from commit 6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1280263
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#18}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/about_flags.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35/components/content_settings/core/common/BUILD.gn
[delete] https://crrev.com/8f6a554f2bb17f3d9588514c937c0275caadfc45/components/content_settings/core/common/features.cc
[delete] https://crrev.com/8f6a554f2bb17f3d9588514c937c0275caadfc45/components/content_settings/core/common/features.h

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/4395f04f508278cd70be5ea2c1b6adcb4ddfcb35

Commit: 4395f04f508278cd70be5ea2c1b6adcb4ddfcb35
Author: engedy@chromium.org
Commiter: engedy@chromium.org
Date: 2018-10-15 08:27:22 +0000 UTC

Remove chrome://flags/#enable-ephemeral-flash-permission.

Bug:  892156 
Change-Id: I2daa27782f4765d7f770505b0a198b5632678cc6
Reviewed-on: https://chromium-review.googlesource.com/c/1264660
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599317}(cherry picked from commit 6374c9b2857c3e078a1df10f687c4b6c1a4d8f9c)
Reviewed-on: https://chromium-review.googlesource.com/c/1280263
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#18}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment