New issue
Advanced search Search tips

Issue 892153 link

Starred by 1 user
Status: Fixed
Owner:
johnidel@chromium.org
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Report per-resource ad metrics separately for cached resources

Project Member Reported by johnidel@chromium.org, Oct 4 
Currently, the Ads.ResourceUsage.Size metrics include both cached and uncached resources causing the histograms to skew low. Cached resources are reported as 0 bytes resources currently. It also make it impossible to distinguish between <1 kilobyte resources and resources that are cached. Separate these into two histograms.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3726b2174964aabc6090dbb289bf6802af42c5c6

commit 3726b2174964aabc6090dbb289bf6802af42c5c6
Author: John Delaney <johnidel@chromium.org>
Date: Thu Oct 11 16:00:54 2018

Record Cached and Uncached resources separately in AdsPageLoadMetrics

Current resources that are cached are being reported as 0 byte
resources in Ads.ResourceUsage.Size.* histograms. This is skewing
the histograms low making it hard to see the real distribution of
resource sizes. Record cached resources in a separate histogram.

Change-Id: I379029ff70ad9f655a8e8887ff7cb5a5a3a08f5e
Bug:  859080 ,  892153 
Reviewed-on: https://chromium-review.googlesource.com/c/1258284
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598783}
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/chrome/renderer/page_load_metrics/page_resource_data_use.cc
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/chrome/renderer/page_load_metrics/page_resource_data_use.h
[modify] https://crrev.com/3726b2174964aabc6090dbb289bf6802af42c5c6/tools/metrics/histograms/histograms.xml

Comment 2 by johnidel@chromium.org, Oct 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment