New issue
Advanced search Search tips

Issue 892150 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros_config: Correct "sig-id-in-customization-id"

Project Member Reported by hungte@chromium.org, Oct 4

Issue description

What steps will reproduce the problem?
(1) Find the signature id in a white label device like blacktip

What is the expected result?
sig-id-in something, maybe vpd or whitelabel-tag

What happens instead?
sig-id-in-customization-id

--

The sig-id-in-customization-id was named before we decided WLs should use 'whitelabel_tag' instead of customization-id.

The firmware updater today is treating sig-id-in-* as "need to replace from vod whitelabel_tag". But the cros-config/README is still documenting that this value will read from VPD 'customization_id', which is wrong.

I think we should change it to a name more close to implementation today.

Maybe 'sig-id-in-vpd', or 'sig-id-in-whitelabel-tag'.

 
Components: Infra>Client>ChromeOS>Build
Will clean this up as part of the migration of coral/fizz
Status: Assigned (was: Untriaged)

Sign in to add a comment